|WARNING| pw115566 [PATCH 1/2] net/iavf: enable TSO offloading for tunnel cases

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115566

_coding style issues_


WARNING:BAD_SIGN_OFF: email address 'beilei.xing at intel.com, jingjing.wu at intel.com,' might be better as 'beilei.xing at intel.com,jingjing.wu at intel.com,'
#199: 
Cc: beilei.xing at intel.com, jingjing.wu at intel.com,

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#256: FILE: drivers/net/iavf/iavf_rxtx.c:2646:
+#define IAVF_MAX_DATA_PER_TXD \
+     (IAVF_TXD_QW1_TX_BUF_SZ_MASK >> IAVF_TXD_QW1_TX_BUF_SZ_SHIFT)

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#261: FILE: drivers/net/iavf/iavf_rxtx.c:2651:
+                  volatile uint64_t desc_template, struct iavf_tx_entry *txe,

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#262: FILE: drivers/net/iavf/iavf_rxtx.c:2652:
+                  volatile struct iavf_tx_desc *txr, struct iavf_tx_entry *txe_ring,

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#271: FILE: drivers/net/iavf/iavf_rxtx.c:2661:
+           while ((m->ol_flags & RTE_MBUF_F_TX_TCP_SEG) &&
[...]
+                 txd->buffer_addr = rte_cpu_to_le_64(buf_dma_addr);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#273: FILE: drivers/net/iavf/iavf_rxtx.c:2663:
+                 txd->buffer_addr = rte_cpu_to_le_64(buf_dma_addr);

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#278: FILE: drivers/net/iavf/iavf_rxtx.c:2668:
+                 IAVF_TXD_DATA_QW1_TX_BUF_SZ_SHIFT) | desc_template;

WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#292: FILE: drivers/net/iavf/iavf_rxtx.c:2682:
+                 rte_cpu_to_le_64((uint64_t)slen << IAVF_TXD_DATA_QW1_TX_BUF_SZ_SHIFT) |

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#323: FILE: drivers/net/iavf/iavf_rxtx.c:2835:
+                 if (nb_desc_ipsec) {
+                       iavf_fill_data_desc(ddesc, mb_seg,

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#324: FILE: drivers/net/iavf/iavf_rxtx.c:2836:
+                       iavf_fill_data_desc(ddesc, mb_seg,

WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#325: FILE: drivers/net/iavf/iavf_rxtx.c:2837:
+                             ddesc_template, tlen, ipseclen);

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#326: FILE: drivers/net/iavf/iavf_rxtx.c:2838:
+                       IAVF_DUMP_TX_DESC(txq, ddesc, desc_idx);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#327: FILE: drivers/net/iavf/iavf_rxtx.c:2839:
+                 } else {
+                       iavf_fill_unencrypt_desc(txd, mb_seg,

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#328: FILE: drivers/net/iavf/iavf_rxtx.c:2840:
+                       iavf_fill_unencrypt_desc(txd, mb_seg,

WARNING:LONG_LINE: line length of 138 exceeds 100 columns
#329: FILE: drivers/net/iavf/iavf_rxtx.c:2841:
+                             ddesc_template, txe, txr, txe_ring, desc_idx_last);

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#330: FILE: drivers/net/iavf/iavf_rxtx.c:2842:
+                       IAVF_DUMP_TX_DESC(txq, txd, desc_idx);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#340: FILE: drivers/net/iavf/iavf_rxtx.c:2868:
+           if (nb_desc_ipsec) {
+                 ddesc->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<

WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#341: FILE: drivers/net/iavf/iavf_rxtx.c:2869:
+                 ddesc->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#346: FILE: drivers/net/iavf/iavf_rxtx.c:2872:
+           } else {
+                 txd->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<

WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#347: FILE: drivers/net/iavf/iavf_rxtx.c:2873:
+                 txd->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<

total: 1 errors, 19 warnings, 0 checks, 98 lines checked