|WARNING| pw120991 [PATCH] lib/net: added push MPLS header API

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Dec 17 19:00:31 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/120991

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#76: 
Push MPLS header after ethernet header, updates ethernet type and MPLS bs bit if required.

ERROR:TRAILING_WHITESPACE: trailing whitespace
#117: FILE: lib/net/rte_mpls.h:45:
+ * $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#121: FILE: lib/net/rte_mpls.h:49:
+ * $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#127: FILE: lib/net/rte_mpls.h:55:
+ *   0 on success, -1 on error (If no ethernet header exists)^I^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#130: FILE: lib/net/rte_mpls.h:58:
+rte_mpls_push_over_l2(struct rte_mbuf **m, struct rte_mpls_hdr *mp) $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#151: FILE: lib/net/rte_mpls.h:79:
+^I$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#153: FILE: lib/net/rte_mpls.h:81:
+	if (nh->ether_type != rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLS))
+	{

ERROR:TRAILING_WHITESPACE: trailing whitespace
#157: FILE: lib/net/rte_mpls.h:85:
+^I}^I$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#158: FILE: lib/net/rte_mpls.h:86:
+	else
+	{

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#158: FILE: lib/net/rte_mpls.h:86:
+	}	
+	else

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#164: FILE: lib/net/rte_mpls.h:92:
+	rte_memcpy(rte_pktmbuf_mtod_offset(*m, char*, sizeof(struct rte_ether_hdr)), mp, RTE_MPLS_HLEN);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#165: FILE: lib/net/rte_mpls.h:93:
+^I$

ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Tanzeel-inline <tanxeel1.ahmed at gmail.com>'

total: 11 errors, 2 warnings, 78 lines checked
Tanzeel Ahmed <tanzeelahmed713 at gmail.com> is unknown, please fix the commit message or update .mailmap.


More information about the test-report mailing list