|WARNING| pw121146 [PATCH v2] net/ice: add devargs for disabling mac filter

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Dec 21 05:16:50 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121146

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#99: FILE: doc/guides/nics/ice.rst:116:
+    $

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY'
#189: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'actions[0].type == RTE_FLOW_ACTION_TYPE_DROP'
#189: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#190: FILE: drivers/net/ice/ice_generic_flow.c:2483:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ad->devargs.mac_filter_disable == 1'
#203: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flow->rule == NULL'
#203: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#204: FILE: drivers/net/ice/ice_generic_flow.c:2520:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

total: 1 errors, 0 warnings, 6 checks, 102 lines checked
"ke1x.zhang" <ke1x.zhang at intel.com> is unknown, please fix the commit message or update .mailmap.
ke1x.zhang <ke1x.zhang at intel.com> is unknown, please fix the commit message or update .mailmap.


More information about the test-report mailing list