|WARNING| pw121199 [PATCH 4/4] event/cnxk: restructure for cn10k datapath

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Dec 21 10:17:53 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121199

_coding style issues_


WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#585: FILE: drivers/event/cnxk/cn10k_tx_worker.h:221:
+#define T(name, sz, flags)                                                     \
+	uint16_t __rte_hot cn10k_sso_hws_tx_adptr_enq_##name(                  \
+		void *port, struct rte_event ev[], uint16_t nb_events);        \
+	uint16_t __rte_hot cn10k_sso_hws_tx_adptr_enq_seg_##name(              \
+		void *port, struct rte_event ev[], uint16_t nb_events);

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#594: FILE: drivers/event/cnxk/cn10k_tx_worker.h:230:
+#define SSO_TX(fn, sz, flags)                                                  \
+	uint16_t __rte_hot fn(void *port, struct rte_event ev[],               \
+			      uint16_t nb_events)                              \
+	{                                                                      \
+		struct cn10k_sso_hws *ws = port;                               \
+		uint64_t cmd[sz];                                              \
+		RTE_SET_USED(nb_events);                                       \
+		return cn10k_sso_hws_event_tx(                                 \
+			ws, &ev[0], cmd, (const uint64_t *)ws->tx_adptr_data,  \
+			flags);                                                \
+	}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#606: FILE: drivers/event/cnxk/cn10k_tx_worker.h:242:
+#define SSO_TX_SEG(fn, sz, flags)                                              \
+	uint16_t __rte_hot fn(void *port, struct rte_event ev[],               \
+			      uint16_t nb_events)                              \
+	{                                                                      \
+		uint64_t cmd[(sz) + CNXK_NIX_TX_MSEG_SG_DWORDS - 2];           \
+		struct cn10k_sso_hws *ws = port;                               \
+		RTE_SET_USED(nb_events);                                       \
+		return cn10k_sso_hws_event_tx(                                 \
+			ws, &ev[0], cmd, (const uint64_t *)ws->tx_adptr_data,  \
+			(flags) | NIX_TX_MULTI_SEG_F);                         \
+	}

total: 0 errors, 3 warnings, 2687 lines checked


More information about the test-report mailing list