|WARNING| pw106850 [PATCH v5] eventdev/eth_rx: fix memory leak when token parsing finished

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Feb 4 08:49:55 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106850

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#102: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:296:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(id, retval) do { \
+	if (!rxa_validate_id(id)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+		ret = retval; \
+		goto error; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#110: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:304:
+#define RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, retval) do { \
+	if ((token) == NULL || strlen(token) == 0 || !isdigit(*token)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter token
"); \
+		ret = retval; \
+		goto error; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#118: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:312:
+#define RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(port_id, retval) do { \
+	if (!rte_eth_dev_is_valid_port(port_id)) { \
+		RTE_ETHDEV_LOG(ERR, "Invalid port_id=%u
", port_id); \
+		ret = retval; \
+		goto error; \
+	} \
+} while (0)

total: 0 errors, 3 warnings, 235 lines checked


More information about the test-report mailing list