|WARNING| pw107112 [PATCH v2 03/12] net/ngbe: fix Tx pending

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Feb 9 11:37:06 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/107112

_coding style issues_


WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#58: 
Add commands requesting firmware to enable or disable PCIe bus master.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#59: 
Disable PCIe master access to clear BME when stop hardware, and verify

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#62: 
Move disabling Tx queue after disabling PCIe bus master, to ensure that

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#116: FILE: drivers/net/ngbe/base/ngbe_hw.c:386:
+	 * Prevent the PCI-E bus from hanging by disabling PCI-E master

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#119: FILE: drivers/net/ngbe/base/ngbe_hw.c:389:
+	status = ngbe_set_pcie_master(hw, false);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#134: FILE: drivers/net/ngbe/base/ngbe_hw.c:1091:
+ *  ngbe_set_pcie_master - Disable or Enable PCI-express master access

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#134: FILE: drivers/net/ngbe/base/ngbe_hw.c:1091:
+ *  ngbe_set_pcie_master - Disable or Enable PCI-express master access

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#137: FILE: drivers/net/ngbe/base/ngbe_hw.c:1094:
+ *  Disables PCI-Express master access and verifies there are no pending

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#138: FILE: drivers/net/ngbe/base/ngbe_hw.c:1095:
+ *  requests. NGBE_ERR_MASTER_REQUESTS_PENDING is returned if master disable

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#138: FILE: drivers/net/ngbe/base/ngbe_hw.c:1095:
+ *  requests. NGBE_ERR_MASTER_REQUESTS_PENDING is returned if master disable

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#139: FILE: drivers/net/ngbe/base/ngbe_hw.c:1096:
+ *  bit hasn't caused the master requests to be disabled, else 0

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#140: FILE: drivers/net/ngbe/base/ngbe_hw.c:1097:
+ *  is returned signifying master requests disabled.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#142: FILE: drivers/net/ngbe/base/ngbe_hw.c:1099:
+s32 ngbe_set_pcie_master(struct ngbe_hw *hw, bool enable)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#148: FILE: drivers/net/ngbe/base/ngbe_hw.c:1105:
+	DEBUGFUNC("ngbe_set_pcie_master");

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#161: FILE: drivers/net/ngbe/base/ngbe_hw.c:1118:
+	/* Exit if master requests are blocked */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#166: FILE: drivers/net/ngbe/base/ngbe_hw.c:1123:
+	/* Poll for master request bit to clear */

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#167: FILE: drivers/net/ngbe/base/ngbe_hw.c:1124:
+	for (i = 0; i < NGBE_PCI_MASTER_DISABLE_TIMEOUT; i++) {

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#174: FILE: drivers/net/ngbe/base/ngbe_hw.c:1131:
+	status = NGBE_ERR_MASTER_REQUESTS_PENDING;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#191: FILE: drivers/net/ngbe/base/ngbe_hw.h:57:
+s32 ngbe_set_pcie_master(struct ngbe_hw *hw, bool enable);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#326: FILE: drivers/net/ngbe/base/ngbe_type.h:20:
+#define NGBE_PCI_MASTER_DISABLE_TIMEOUT	800

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#348: FILE: drivers/net/ngbe/ngbe_ethdev.c:963:
+	ngbe_set_pcie_master(hw, true);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#357: FILE: drivers/net/ngbe/ngbe_ethdev.c:1178:
+	ngbe_set_pcie_master(hw, true);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#366: FILE: drivers/net/ngbe/ngbe_ethdev.c:1208:
+	ngbe_set_pcie_master(hw, false);

total: 0 errors, 23 warnings, 0 checks, 251 lines checked


More information about the test-report mailing list