|WARNING| pw107738 [PATCH v3 01/15] bus/vmbus: scan and get the network device

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Feb 17 17:11:15 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/107738

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#123: FILE: drivers/bus/vmbus/freebsd/vmbus_bus.c:27:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#309: FILE: drivers/bus/vmbus/freebsd/vmbus_bus.c:213:
+#define UNPACK(x)						 \
+	do {							 \
+		x = strdup(walker);				 \
+		if (x == NULL)					 \
+			return -ENOMEM;				 \
+		if (walker + strnlen(walker, ep - walker) >= ep) \
+			return -EINVAL;				 \
+		walker += strlen(walker) + 1;			 \
+	} while (0)

total: 0 errors, 2 warnings, 249 lines checked


More information about the test-report mailing list