|WARNING| pw108255-108257 [PATCH] [v3, 3/3] net/mlx5: add wait on time support in Tx datapath

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Thu Feb 24 13:38:51 CET 2022


Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/108255

_apply patch failure_

Submitter: Slava Ovsiienko <viacheslavo at nvidia.com>
Date: Thursday, February 24 2022 10:55:01 
Applied on: CommitID:ee05a93e1e6633d0fdec409faf09f12a2e05b991
Apply patch set 108255-108257 failed:

Checking patch drivers/net/mlx5/linux/mlx5_verbs.c...
Hunk #1 succeeded at 1036 (offset 1 line).
Checking patch drivers/net/mlx5/mlx5.h...
Hunk #1 succeeded at 341 (offset 4 lines).
Checking patch drivers/net/mlx5/mlx5_devx.c...
error: while searching for:
	txq_data->qp_num_8s = txq_obj->sq_obj.sq->id << 8;
	txq_data->db_heu = sh->cdev->config.dbnc == MLX5_SQ_DB_HEURISTIC;
	txq_data->db_nc = sh->tx_uar.dbnc;
	/* Change Send Queue state to Ready-to-Send. */
	ret = mlx5_txq_devx_modify(txq_obj, MLX5_TXQ_MOD_RST2RDY, 0);
	if (ret) {

error: patch failed: drivers/net/mlx5/mlx5_devx.c:1328
Checking patch drivers/net/mlx5/mlx5_tx.h...
Checking patch drivers/net/mlx5/mlx5_txq.c...
error: while searching for:
			     RTE_ETH_TX_OFFLOAD_TCP_CKSUM);
	if (dev_cap->tso)
		offloads |= RTE_ETH_TX_OFFLOAD_TCP_TSO;
	if (priv->sh->config.tx_pp)
		offloads |= RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP;
	if (dev_cap->swp) {
		if (dev_cap->swp & MLX5_SW_PARSING_CSUM_CAP)

error: patch failed: drivers/net/mlx5/mlx5_txq.c:109
Hunk #2 succeeded at 1290 (offset 1 line).
Hunk #3 succeeded at 1313 (offset 1 line).
Applied patch drivers/net/mlx5/linux/mlx5_verbs.c cleanly.
Applied patch drivers/net/mlx5/mlx5.h cleanly.
Applying patch drivers/net/mlx5/mlx5_devx.c with 1 reject...
Rejected hunk #1.
Applied patch drivers/net/mlx5/mlx5_tx.h cleanly.
Applying patch drivers/net/mlx5/mlx5_txq.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
diff a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c	(rejected hunks)
@@ -1328,6 +1328,8 @@ mlx5_txq_devx_obj_new(struct rte_eth_dev *dev, uint16_t idx)
 	txq_data->qp_num_8s = txq_obj->sq_obj.sq->id << 8;
 	txq_data->db_heu = sh->cdev->config.dbnc == MLX5_SQ_DB_HEURISTIC;
 	txq_data->db_nc = sh->tx_uar.dbnc;
+	txq_data->wait_on_time = !!(!sh->config.tx_pp &&
+				    sh->cdev->config.hca_attr.wait_on_time);
 	/* Change Send Queue state to Ready-to-Send. */
 	ret = mlx5_txq_devx_modify(txq_obj, MLX5_TXQ_MOD_RST2RDY, 0);
 	if (ret) {
diff a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c	(rejected hunks)
@@ -109,7 +109,8 @@ mlx5_get_tx_port_offloads(struct rte_eth_dev *dev)
 			     RTE_ETH_TX_OFFLOAD_TCP_CKSUM);
 	if (dev_cap->tso)
 		offloads |= RTE_ETH_TX_OFFLOAD_TCP_TSO;
-	if (priv->sh->config.tx_pp)
+	if (priv->sh->config.tx_pp ||
+	    priv->sh->cdev->config.hca_attr.wait_on_time)
 		offloads |= RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP;
 	if (dev_cap->swp) {
 		if (dev_cap->swp & MLX5_SW_PARSING_CSUM_CAP)
Checking patch doc/guides/nics/mlx5.rst...
Hunk #1 succeeded at 934 (offset 105 lines).
Checking patch doc/guides/rel_notes/release_22_03.rst...
error: while searching for:
  * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
    src/dst address and UDP/TCP src/dst port.

* **Updated Wangxun ngbe driver.**

  * Added support for devices of custom PHY interfaces.

error: patch failed: doc/guides/rel_notes/release_22_03.rst:118
Checking patch drivers/net/mlx5/mlx5_tx.h...
error: drivers/net/mlx5/mlx5_tx.h: does not match index
Applied patch doc/guides/nics/mlx5.rst cleanly.
Applying patch doc/guides/rel_notes/release_22_03.rst with 1 reject...
Rejected hunk #1.
diff a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst	(rejected hunks)
@@ -118,6 +118,12 @@ New Features
   * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
     src/dst address and UDP/TCP src/dst port.
 
+* **Updated Mellanox mlx5 driver.**
+
+  Updated the Mellanox mlx5 driver with new features and improvements, including:
+
+  * Support ConnectX-7 capability to schedule traffic sending on timestamp
+
 * **Updated Wangxun ngbe driver.**
 
   * Added support for devices of custom PHY interfaces.

https://lab.dpdk.org/results/dashboard/patchsets/21249/

UNH-IOL DPDK Community Lab


More information about the test-report mailing list