|WARNING| pw108286 [PATCH 2/2] event/cnxk: align perfetchs to CN10K cache model

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108286

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#153: FILE: drivers/net/cnxk/cn10k_rx.h:39:
+#define CQE_PTR_DIFF(b, i, o, f)                                               \
+	(((f) & NIX_RX_VWQE_F) ?                                               \
+		 (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) :       \
+		       (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#153: FILE: drivers/net/cnxk/cn10k_rx.h:39:
+#define CQE_PTR_DIFF(b, i, o, f)                                               \
+	(((f) & NIX_RX_VWQE_F) ?                                               \
+		 (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) :       \
+		       (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'o' - possible side-effects?
#153: FILE: drivers/net/cnxk/cn10k_rx.h:39:
+#define CQE_PTR_DIFF(b, i, o, f)                                               \
+	(((f) & NIX_RX_VWQE_F) ?                                               \
+		 (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) :       \
+		       (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o)))

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#159: FILE: drivers/net/cnxk/cn10k_rx.h:45:
+#define NIX_MBUF_VALIDATE_NEXT(m)                                              \
+	if (m->nb_segs == 1 && mbuf->next) {                                   \
+		rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d",     \
+			  m->next, m->nb_segs);                                \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects?
#159: FILE: drivers/net/cnxk/cn10k_rx.h:45:
+#define NIX_MBUF_VALIDATE_NEXT(m)                                              \
+	if (m->nb_segs == 1 && mbuf->next) {                                   \
+		rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d",     \
+			  m->next, m->nb_segs);                                \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'm' may be better as '(m)' to avoid precedence issues
#159: FILE: drivers/net/cnxk/cn10k_rx.h:45:
+#define NIX_MBUF_VALIDATE_NEXT(m)                                              \
+	if (m->nb_segs == 1 && mbuf->next) {                                   \
+		rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d",     \
+			  m->next, m->nb_segs);                                \
+	}

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#189: FILE: drivers/net/cnxk/cn10k_rx.h:695:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#191: FILE: drivers/net/cnxk/cn10k_rx.h:697:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#193: FILE: drivers/net/cnxk/cn10k_rx.h:699:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#195: FILE: drivers/net/cnxk/cn10k_rx.h:701:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#199: FILE: drivers/net/cnxk/cn10k_rx.h:705:
+					rte_prefetch1(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#201: FILE: drivers/net/cnxk/cn10k_rx.h:707:
+					rte_prefetch1(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#203: FILE: drivers/net/cnxk/cn10k_rx.h:709:
+					rte_prefetch1(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#205: FILE: drivers/net/cnxk/cn10k_rx.h:711:
+					rte_prefetch1(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#208: FILE: drivers/net/cnxk/cn10k_rx.h:714:
+						rte_prefetch1(CQE_PTR_OFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#210: FILE: drivers/net/cnxk/cn10k_rx.h:716:
+						rte_prefetch1(CQE_PTR_OFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#212: FILE: drivers/net/cnxk/cn10k_rx.h:718:
+						rte_prefetch1(CQE_PTR_OFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#214: FILE: drivers/net/cnxk/cn10k_rx.h:720:
+						rte_prefetch1(CQE_PTR_OFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#219: FILE: drivers/net/cnxk/cn10k_rx.h:725:
+				rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#221: FILE: drivers/net/cnxk/cn10k_rx.h:727:
+				rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#223: FILE: drivers/net/cnxk/cn10k_rx.h:729:
+				rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#225: FILE: drivers/net/cnxk/cn10k_rx.h:731:
+				rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#228: FILE: drivers/net/cnxk/cn10k_rx.h:734:
+					rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#231: FILE: drivers/net/cnxk/cn10k_rx.h:737:
+					rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#234: FILE: drivers/net/cnxk/cn10k_rx.h:740:
+					rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#237: FILE: drivers/net/cnxk/cn10k_rx.h:743:
+					rte_prefetch0(CQE_PTR_DIFF(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#244: FILE: drivers/net/cnxk/cn10k_rx.h:750:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#246: FILE: drivers/net/cnxk/cn10k_rx.h:752:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#248: FILE: drivers/net/cnxk/cn10k_rx.h:754:
+				rte_prefetch_non_temporal(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#250: FILE: drivers/net/cnxk/cn10k_rx.h:756:
+				rte_prefetch_non_temporal(

total: 1 errors, 0 warnings, 29 checks, 191 lines checked
Warning in drivers/net/cnxk/cn10k_rx.h:
Using rte_panic/rte_exit