|WARNING| pw105580 [PATCH 5/8] app/test: add unit cases for inline IPsec offload

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105580

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#390: FILE: app/test/test_inline_ipsec.c:273:
+copy_buf_to_pkt_segs(void *buf, unsigned len, struct rte_mbuf *pkt,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#391: FILE: app/test/test_inline_ipsec.c:274:
+		unsigned offset)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#395: FILE: app/test/test_inline_ipsec.c:278:
+	unsigned copy_len;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#415: FILE: app/test/test_inline_ipsec.c:298:
+copy_buf_to_pkt(void *buf, unsigned len, struct rte_mbuf *pkt, unsigned offset)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#415: FILE: app/test/test_inline_ipsec.c:298:
+copy_buf_to_pkt(void *buf, unsigned len, struct rte_mbuf *pkt, unsigned offset)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#436: FILE: app/test/test_inline_ipsec.c:319:
+		if (pkt == NULL) {
+			return TEST_FAILED;
+		}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#452: FILE: app/test/test_inline_ipsec.c:335:
+	unsigned lcore_id;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#469: FILE: app/test/test_inline_ipsec.c:352:
+init_mempools(unsigned nb_mbuf)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#473: FILE: app/test/test_inline_ipsec.c:356:
+	unsigned lcore_id;

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#520: FILE: app/test/test_inline_ipsec.c:403:
+				return TEST_FAILED;
+			} else

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#536: FILE: app/test/test_inline_ipsec.c:419:
+				return TEST_FAILED;
+			} else

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#586: FILE: app/test/test_inline_ipsec.c:469:
+	unsigned i, portid, nb_rx = 0, nb_tx = 1;

WARNING:TYPO_SPELLING: 'eanble' may be misspelled - perhaps 'enable'?
#669: FILE: app/test/test_inline_ipsec.c:552:
+	/* always eanble promiscuous */

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#799: FILE: app/test/test_inline_ipsec.c:682:
+static int
+test_ipsec_ipv4_encap_nofrag(void) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#811: FILE: app/test/test_inline_ipsec.c:694:
+static int
+test_ipsec_ipv4_decap_nofrag(void) {

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#964: FILE: app/test/test_inline_ipsec_reassembly_vectors.h:113:
+	 * l4_offset for UDP header */

ERROR:SPACING: space required after that ';' (ctx:BxV)
#982: FILE: app/test/test_inline_ipsec_reassembly_vectors.h:131:
+	for (;vector->frags[i] != NULL && i < MAX_FRAGS; i++)
 	     ^

total: 3 errors, 14 warnings, 933 lines checked