|WARNING| pw106610 [PATCH 3/5] examples/fips_validation: add json parsing
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Jan 27 15:52:40 CET 2022
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106610
_coding style issues_
WARNING:TYPO_SPELLING: 'PERFIX' may be misspelled - perhaps 'PREFIX'?
#93: FILE: examples/fips_validation/fips_validation.c:279:
+ else if (strstr(path, JSON_FILE_PERFIX))
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#124: FILE: examples/fips_validation/fips_validation.c:349:
+ if (info.file_type == FIPS_TYPE_JSON) return 0;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#141: FILE: examples/fips_validation/fips_validation.c:459:
+ if (strstr(algo_str, "AES-GCM")) info.algo = FIPS_TEST_ALGO_AES_GCM;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#142: FILE: examples/fips_validation/fips_validation.c:460:
+ else return -EINVAL;
WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#155: FILE: examples/fips_validation/fips_validation.c:473:
+ json_t *param = json_object_get(json_info.json_test_group, info.interim_callbacks[i].key);
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#159: FILE: examples/fips_validation/fips_validation.c:477:
+ /* First argument is blank because the key
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#159: FILE: examples/fips_validation/fips_validation.c:477:
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#184: FILE: examples/fips_validation/fips_validation.c:502:
+ /* First argument is blank because the key
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#184: FILE: examples/fips_validation/fips_validation.c:502:
+ is not included in the string being parsed. */
total: 3 errors, 6 warnings, 108 lines checked
Warning in examples/fips_validation/fips_validation.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t
Warning in examples/fips_validation/fips_validation.c:
Declaring a variable inside for()
More information about the test-report
mailing list