|WARNING| pw106709 [PATCH v2 3/5] examples/fips_validation: add json parsing

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106709

_coding style issues_


ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#139: FILE: examples/fips_validation/fips_validation.c:349:
+	if (info.file_type == FIPS_TYPE_JSON) return 0;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#156: FILE: examples/fips_validation/fips_validation.c:459:
+	if (strstr(algo_str, "AES-GCM")) info.algo = FIPS_TEST_ALGO_AES_GCM;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#157: FILE: examples/fips_validation/fips_validation.c:460:
+	else return -EINVAL;

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#170: FILE: examples/fips_validation/fips_validation.c:473:
+			json_t *param = json_object_get(json_info.json_test_group, info.interim_callbacks[i].key);

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#174: FILE: examples/fips_validation/fips_validation.c:477:
+			/* First argument is blank because the key
+			   is not included in the string being parsed. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: examples/fips_validation/fips_validation.c:477:
+			   is not included in the string being parsed. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#199: FILE: examples/fips_validation/fips_validation.c:502:
+			/* First argument is blank because the key
+			   is not included in the string being parsed. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#199: FILE: examples/fips_validation/fips_validation.c:502:
+			   is not included in the string being parsed. */

total: 3 errors, 5 warnings, 117 lines checked
Warning in examples/fips_validation/fips_validation.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t