|WARNING| pw113587 [PATCH v4 05/12] net/nfp: add flower PF setup and mempool init logic

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jul 1 04:23:32 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113587

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#310: FILE: drivers/net/nfp/flower/nfp_flower.c:194:
+	PMD_INIT_LOG(DEBUG, "%s vNIC tx_bar_off: 0x%" PRIx64,

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Y' - possible side-effects?
#621: FILE: drivers/net/nfp/flower/nfp_flower_ovs_compat.h:15:
+#define ROUND_UP(X, Y) (DIV_ROUND_UP(X, Y) * (Y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MEMBERS' - possible side-effects?
#626: FILE: drivers/net/nfp/flower/nfp_flower_ovs_compat.h:20:
+#define PADDED_MEMBERS_CACHELINE_MARKER(UNIT, CACHELINE, MEMBERS)   \
+	union {                                                         \
+		OVS_CACHE_LINE_MARKER CACHELINE;                            \
+		struct { MEMBERS };                                         \
+		uint8_t PAD_ID[ROUND_UP(sizeof(struct { MEMBERS }), UNIT)]; \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MEMBERS' - possible side-effects?
#633: FILE: drivers/net/nfp/flower/nfp_flower_ovs_compat.h:27:
+#define PADDED_MEMBERS_CACHELINE_MARKER(UNIT, CACHELINE, MEMBERS)           \
+	struct struct_##CACHELINE { MEMBERS };                                  \
+	union {                                                                 \
+		OVS_CACHE_LINE_MARKER CACHELINE;                                    \
+		struct { MEMBERS };                                                 \
+		uint8_t PAD_ID[ROUND_UP(sizeof(struct struct_##CACHELINE), UNIT)];  \
+	}

total: 0 errors, 0 warnings, 4 checks, 590 lines checked


More information about the test-report mailing list