|WARNING| pw112612 [PATCH v5] app/testpmd: fix slave device isn't released

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 9 13:51:13 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/112612

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#34: 
Subject: [PATCH v5] app/testpmd: fix slave device isn't released

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#62: 
release operation for all active slaves under a bond device.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#108: FILE: app/test-pmd/testpmd.c:3206:
+clear_bonding_slave_device(portid_t *slave_pids, uint16_t num_slaves)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#108: FILE: app/test-pmd/testpmd.c:3206:
+clear_bonding_slave_device(portid_t *slave_pids, uint16_t num_slaves)

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#108: FILE: app/test-pmd/testpmd.c:3206:
+clear_bonding_slave_device(portid_t *slave_pids, uint16_t num_slaves)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#111: FILE: app/test-pmd/testpmd.c:3209:
+	portid_t slave_pid;

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#114: FILE: app/test-pmd/testpmd.c:3212:
+	for (i = 0; i < num_slaves; i++) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#115: FILE: app/test-pmd/testpmd.c:3213:
+		slave_pid = slave_pids[i];

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#115: FILE: app/test-pmd/testpmd.c:3213:
+		slave_pid = slave_pids[i];

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#116: FILE: app/test-pmd/testpmd.c:3214:
+		if (port_is_started(slave_pid) == 1) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#117: FILE: app/test-pmd/testpmd.c:3215:
+			if (rte_eth_dev_stop(slave_pid) != 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#119: FILE: app/test-pmd/testpmd.c:3217:
+					slave_pid);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#121: FILE: app/test-pmd/testpmd.c:3219:
+			port = &ports[slave_pid];

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#125: FILE: app/test-pmd/testpmd.c:3223:
+		clear_port_slave_flag(slave_pid);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#125: FILE: app/test-pmd/testpmd.c:3223:
+		clear_port_slave_flag(slave_pid);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#127: FILE: app/test-pmd/testpmd.c:3225:
+		/* Close slave device when testpmd quit or is killed. */

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#129: FILE: app/test-pmd/testpmd.c:3227:
+			rte_eth_dev_close(slave_pid);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#138: FILE: app/test-pmd/testpmd.c:3236:
+	portid_t slave_pids[RTE_MAX_ETHPORTS];

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#139: FILE: app/test-pmd/testpmd.c:3237:
+	int num_slaves = 0;

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#149: FILE: app/test-pmd/testpmd.c:3274:
+				num_slaves = rte_eth_bond_slaves_get(pi,

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#149: FILE: app/test-pmd/testpmd.c:3274:
+				num_slaves = rte_eth_bond_slaves_get(pi,

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#150: FILE: app/test-pmd/testpmd.c:3275:
+						slave_pids, RTE_MAX_ETHPORTS);

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#154: FILE: app/test-pmd/testpmd.c:3279:
+			 * If this port is bonded device, all slaves under the

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#157: FILE: app/test-pmd/testpmd.c:3282:
+			if (port->bond_flag == 1 && num_slaves > 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#158: FILE: app/test-pmd/testpmd.c:3283:
+				clear_bonding_slave_device(slave_pids,

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#158: FILE: app/test-pmd/testpmd.c:3283:
+				clear_bonding_slave_device(slave_pids,

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#159: FILE: app/test-pmd/testpmd.c:3284:
+							num_slaves);

total: 0 errors, 27 warnings, 80 lines checked


More information about the test-report mailing list