|WARNING| pw108798 [RFC PATCH 2/2] test: add proper pkcs1 signature tests for rsa

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 22 09:12:18 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108798

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#147: FILE: app/test/test_cryptodev_asym.c:226:
+^I0x00, 0x01, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#148: FILE: app/test/test_cryptodev_asym.c:227:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#149: FILE: app/test/test_cryptodev_asym.c:228:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#150: FILE: app/test/test_cryptodev_asym.c:229:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#151: FILE: app/test/test_cryptodev_asym.c:230:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#152: FILE: app/test/test_cryptodev_asym.c:231:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#153: FILE: app/test/test_cryptodev_asym.c:232:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#154: FILE: app/test/test_cryptodev_asym.c:233:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#155: FILE: app/test/test_cryptodev_asym.c:234:
+^I0xFF, 0xFF, 0xFF, 0xFF,^I0xFF, 0xFF, 0xFF, 0xFF, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#157: FILE: app/test/test_cryptodev_asym.c:236:
+^I0x0d, 0x06, 0x09, 0x60,^I0x86, 0x48, 0x01, 0x65, $

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#171: FILE: app/test/test_cryptodev_asym.c:250:
+	static void *sess = NULL;

ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#187: FILE: app/test/test_cryptodev_asym.c:266:
+struct rfc2207_rsa_test_data
+{

WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#335: FILE: app/test/test_cryptodev_asym.c:2381:
+		TEST_CASE_NAMED_WITH_DATA("rfc2207_rsa_sign_pkcs_15_ssl23", ut_setup_asym, ut_teardown_asym,

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#337: FILE: app/test/test_cryptodev_asym.c:2383:
+		TEST_CASE_NAMED_WITH_DATA("rfc2207_rsa_sign_pkcs_15_ssl23_padded", ut_setup_asym, ut_teardown_asym,

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#339: FILE: app/test/test_cryptodev_asym.c:2385:
+		TEST_CASE_NAMED_WITH_DATA("rfc2207_rsa_sign_pkcs_15_sha1", ut_setup_asym, ut_teardown_asym,

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#341: FILE: app/test/test_cryptodev_asym.c:2387:
+		TEST_CASE_NAMED_WITH_DATA("rfc2207_rsa_sign_pkcs_15_digestinfo_sha1", ut_setup_asym, ut_teardown_asym,

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#342: FILE: app/test/test_cryptodev_asym.c:2388:
+				rfc2207_rsa_sign_pkcs_15, &rfc2207_rsa_test_data_pkcs15_digestinfo_sha1),

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#343: FILE: app/test/test_cryptodev_asym.c:2389:
+		TEST_CASE_NAMED_WITH_DATA("rfc2207_rsa_sign_pkcs_15_sha256", ut_setup_asym, ut_teardown_asym,

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#345: FILE: app/test/test_cryptodev_asym.c:2391:
+		TEST_CASE_NAMED_WITH_DATA("rfc2207_rsa_sign_pkcs_15_digestinfo_sha256", ut_setup_asym, ut_teardown_asym,

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#346: FILE: app/test/test_cryptodev_asym.c:2392:
+				rfc2207_rsa_sign_pkcs_15, &rfc2207_rsa_test_data_pkcs15_digestinfo_sha256),

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#400: FILE: drivers/crypto/openssl/rte_openssl_pmd.c:1967:
+						op->rsa.output.data, (unsigned int *)&op->rsa.output.length, rsa);

total: 12 errors, 9 warnings, 352 lines checked
Warning in app/test/test_cryptodev_asym.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t


More information about the test-report mailing list