|WARNING| pw120142 [PATCH] net/ice: add devargs for disabling mac filter

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/120142

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY'
#163: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'actions[0].type == RTE_FLOW_ACTION_TYPE_DROP'
#163: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#164: FILE: drivers/net/ice/ice_generic_flow.c:2483:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ad->devargs.mac_filter_disable == 1'
#177: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flow->rule == NULL'
#177: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#178: FILE: drivers/net/ice/ice_generic_flow.c:2520:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

total: 0 errors, 0 warnings, 6 checks, 85 lines checked