|WARNING| pw120286 [PATCH] [v4, 5/5] failsafe: make sub-device remove flag thread-safe

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/120286

_apply patch failure_

Submitter: Luc Pelletier <lucp.at.work at gmail.com>
Date: Tuesday, November 29 2022 15:25:17 
Applied on: CommitID:f262f16087ea6a77357a915cf4c0d10ddc7b6562
Apply patch set 120286 failed:

Checking patch drivers/net/failsafe/failsafe_ether.c...
Hunk #1 succeeded at 313 (offset 2 lines).
Hunk #2 succeeded at 390 (offset 2 lines).
Hunk #3 succeeded at 558 (offset 2 lines).
Hunk #4 succeeded at 601 (offset 4 lines).
Checking patch drivers/net/failsafe/failsafe_ops.c...
error: while searching for:
		if (likely(sdev_link_ret == 0)) {
			if (TX_SUBDEV(dev) == sdev)
				ret = rte_eth_linkstatus_set(dev, &link_info);
		} else if (sdev->remove == 0 &&
				rte_eth_dev_is_removed(PORT_ID(sdev)) == 0) {
			ERROR("Link get failed for sub_device %d with error %d",
				i, sdev_link_ret);

error: patch failed: drivers/net/failsafe/failsafe_ops.c:837
Checking patch drivers/net/failsafe/failsafe_private.h...
Hunk #2 succeeded at 498 (offset 8 lines).
Checking patch drivers/net/failsafe/failsafe_rxtx.c...
Applied patch drivers/net/failsafe/failsafe_ether.c cleanly.
Applying patch drivers/net/failsafe/failsafe_ops.c with 1 reject...
Rejected hunk #1.
Applied patch drivers/net/failsafe/failsafe_private.h cleanly.
Applied patch drivers/net/failsafe/failsafe_rxtx.c cleanly.
diff a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c	(rejected hunks)
@@ -837,7 +837,7 @@ fs_link_update(struct rte_eth_dev *dev,
 		if (likely(sdev_link_ret == 0)) {
 			if (TX_SUBDEV(dev) == sdev)
 				ret = rte_eth_linkstatus_set(dev, &link_info);
-		} else if (sdev->remove == 0 &&
+		} else if (__atomic_load_n(&sdev->remove, __ATOMIC_ACQUIRE) == 0 &&
 				rte_eth_dev_is_removed(PORT_ID(sdev)) == 0) {
 			ERROR("Link get failed for sub_device %d with error %d",
 				i, sdev_link_ret);

https://lab.dpdk.org/results/dashboard/patchsets/24594/

UNH-IOL DPDK Community Lab