|WARNING| pw117478 [v2 17/19] net/mlx5/hws: Add HWS action object

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Oct 6 17:08:42 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117478

_coding style issues_


ERROR:SPACING: space required before the open parenthesis '('
#2065: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1921:
+	switch(rule_action->action->type) {

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2217: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2073:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2226: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2082:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2234: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2090:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2250: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2106:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2266: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2122:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_DOUBLE);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#2340: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2196:
+	while (action_type[num_actions++] != MLX5DR_ACTION_TYP_LAST);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_num_of_actions != num_of_actions'
#2702: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:72:
+	if ((cur_num_of_actions != num_of_actions) || (cur_type != type))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_type != type'
#2702: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:72:
+	if ((cur_num_of_actions != num_of_actions) || (cur_type != type))

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#2774: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:144:
+		if (cached_pattern->mh_data.pattern_obj->id == action->modify_header.pattern_obj->id)

CHECK:SPACING: No space is necessary after a cast
#2936: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:306:
+	mlx5dr_action_prepare_decap_l3_data(arg_data, (uint8_t *) wqe_arg,

ERROR:C99_COMMENTS: do not use C99 // comments
#2997: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:367:
+		memset(wqe_ctrl, 0, wqe_len); // TODO OPT: GTA ctrl might be ignored in case of arg

total: 3 errors, 6 warnings, 3 checks, 3068 lines checked
Warning in drivers/net/mlx5/hws/mlx5dr_action.c:
Using rte_atomicNN_xxx


More information about the test-report mailing list