|WARNING| pw118665 [v5 09/18] net/mlx5/hws: Add HWS pool and buddy

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Oct 19 22:59:14 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118665

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#211: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:67:
+		DR_LOG(ERR, "Unexpected bit (%d < %"PRIx64") from bitmap", pos, n);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#211: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:67:
+		DR_LOG(ERR, "Unexpected bit (%d < %"PRIx64") from bitmap", pos, n);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#289: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:145:
+	for (i = 0; i <= (int)buddy->max_order; ++i) {
+		rte_free(buddy->bits[i]);
+	}

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#496: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:117:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#747: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:368:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#769: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:390:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#777: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:398:
+	return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#800: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:421:
+	return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#804: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:425:
+	return ENOMEM;

WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#848: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:469:
+		DR_LOG(ERR, "No mem for general elemnt_manager");

WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#938: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:559:
+		DR_LOG(ERR, "No mem for general elemnt_manager");

total: 0 errors, 9 warnings, 2 checks, 1047 lines checked


More information about the test-report mailing list