|WARNING| pw119121 [PATCH 4/8] ethdev: use GRE protocol struct for flow matching

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Oct 25 23:47:18 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119121

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.k'
#293: FILE: drivers/net/mlx5/mlx5_flow.c:2990:
+	if (gre_spec && (gre_mask->hdr.k) && !(gre_spec->hdr.k))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.c'
#303: FILE: drivers/net/mlx5/mlx5_flow.c:3065:
+		if (gre_spec && (gre_mask->hdr.c) && !(gre_spec->hdr.c))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.k'
#311: FILE: drivers/net/mlx5/mlx5_flow.c:3071:
+		if (gre_spec && (gre_mask->hdr.k) && !(gre_spec->hdr.k))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.s'
#318: FILE: drivers/net/mlx5/mlx5_flow.c:3076:
+		if (gre_spec && (gre_mask->hdr.s) && !(gre_spec->hdr.s))

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#354: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9022:
+	gre_crks_rsvd0_ver_m.value = rte_be_to_cpu_16(*(const uint16_t*)&gre_m->hdr);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#355: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9023:
+	gre_crks_rsvd0_ver_v.value = rte_be_to_cpu_16(*(const uint16_t*)&gre_v->hdr);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#387: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9115:
+	c_rsvd0_ver_v = *(const uint16_t*)&gre_v->hdr;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#388: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9116:
+	c_rsvd0_ver_m = *(const uint16_t*)&gre_m->hdr;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#423: FILE: drivers/net/mlx5/mlx5_flow_verbs.c:962:
+	tunnel.val.c_ks_res0_ver = *(const uint16_t*)&spec->hdr;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#425: FILE: drivers/net/mlx5/mlx5_flow_verbs.c:964:
+	tunnel.mask.c_ks_res0_ver = *(const uint16_t*)&mask->hdr;

total: 6 errors, 0 warnings, 285 lines checked


More information about the test-report mailing list