|WARNING| pw119129 [PATCH] net/mlx5: remove unneeded SQ null checking

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/119129

_apply patch failure_

Submitter: Suanming Mou <suanmingm at nvidia.com>
Date: Wednesday, October 26 2022 06:33:26 
Applied on: CommitID:011c617ca20858ce0ad20625e9d3e4c3d6252047
Apply patch set 119129 failed:

Checking patch drivers/net/mlx5/mlx5_flow_aso.c...
error: while searching for:
	return 0;
error:
	do {
		if (&hws_pool->sq[i])
			mlx5_aso_destroy_sq(hws_pool->sq + i);
	} while (i--);
	return -1;
}

error: patch failed: drivers/net/mlx5/mlx5_flow_aso.c:328
error: while searching for:
	do {
		if (ct_mng->aso_sqs[i].mr.addr)
			mlx5_aso_dereg_mr(sh->cdev, &ct_mng->aso_sqs[i].mr);
		if (&ct_mng->aso_sqs[i])
			mlx5_aso_destroy_sq(&ct_mng->aso_sqs[i]);
	} while (i--);
	ct_mng->nb_sq = 0;
	return -1;

error: patch failed: drivers/net/mlx5/mlx5_flow_aso.c:1149
Applying patch drivers/net/mlx5/mlx5_flow_aso.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c	(rejected hunks)
@@ -328,8 +328,7 @@ mlx5_aso_mtr_queue_init(struct mlx5_dev_ctx_shared *sh,
 	return 0;
 error:
 	do {
-		if (&hws_pool->sq[i])
-			mlx5_aso_destroy_sq(hws_pool->sq + i);
+		mlx5_aso_destroy_sq(hws_pool->sq + i);
 	} while (i--);
 	return -1;
 }
@@ -1149,8 +1148,7 @@ mlx5_aso_ct_queue_init(struct mlx5_dev_ctx_shared *sh,
 	do {
 		if (ct_mng->aso_sqs[i].mr.addr)
 			mlx5_aso_dereg_mr(sh->cdev, &ct_mng->aso_sqs[i].mr);
-		if (&ct_mng->aso_sqs[i])
-			mlx5_aso_destroy_sq(&ct_mng->aso_sqs[i]);
+		mlx5_aso_destroy_sq(&ct_mng->aso_sqs[i]);
 	} while (i--);
 	ct_mng->nb_sq = 0;
 	return -1;

https://lab.dpdk.org/results/dashboard/patchsets/24196/

UNH-IOL DPDK Community Lab