|WARNING| pw116681 [v1 17/19] net/mlx5/hws: Add HWS action object

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116681

_coding style issues_


WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#481: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:339:
+			devx_obj = mlx5dr_pool_chunk_get_base_devx_obj_mirror(stc_attr->ste_table.ste_pool,

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#482: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:340:
+									      &stc_attr->ste_table.ste);

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#494: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:352:
+			/*The FW doesn't allow to go back to wire in the RX side, so change it to DROP*/

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#570: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:428:
+       mlx5dr_pool_chunk_free(stc_pool, stc);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#571: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:429:
+       return rte_errno;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#815: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:673:
+^I^I     ^IMLX5DR_ACTION_FLAG_ROOT_TX |$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#815: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:673:
+^I^I     ^IMLX5DR_ACTION_FLAG_ROOT_TX |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#816: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:674:
+^I^I     ^IMLX5DR_ACTION_FLAG_ROOT_FDB);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#816: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:674:
+^I^I     ^IMLX5DR_ACTION_FLAG_ROOT_FDB);$

WARNING:TYPO_SPELLING: 'quering' may be misspelled - perhaps 'querying'?
#1098: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:956:
+		DR_LOG(ERR, "Failed quering port %d
", ib_port_num);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#1105: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:963:
+		if (ret){
+		DR_LOG(ERR, "Failed creating stc for port %d
", ib_port_num);

ERROR:SPACING: space required before the open brace '{'
#1105: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:963:
+		if (ret){

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1262: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1120:
+	if (flags & MLX5DR_ACTION_FLAG_ROOT_RX) {
[...]
+	} else if (flags & MLX5DR_ACTION_FLAG_ROOT_TX) {
[...]
+	} else if (flags & MLX5DR_ACTION_FLAG_ROOT_FDB) {
[...]

CHECK:SPACING: No space is necessary after a cast
#1497: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1355:
+						  (__be64 *) mh_data, bulk_size);

ERROR:SPACING: space required before the open brace '{'
#2062: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1920:
+	switch(rule_action->action->type){

ERROR:SPACING: space required before the open parenthesis '('
#2062: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1920:
+	switch(rule_action->action->type){

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2191: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2049:
+	last_setter = setter = start_setter;

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2212: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2070:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2221: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2079:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2229: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2087:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2245: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2103:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2261: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2119:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_DOUBLE);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2271: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2129:
+			setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#2334: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2192:
+	while (action_type[num_actions++] != MLX5DR_ACTION_TYP_LAST);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#2407: FILE: drivers/net/mlx5/hws/mlx5dr_action.h:42:
+	MLX5DR_ACTION_HDR_LEN_L2_W_VLAN = (MLX5DR_ACTION_HDR_LEN_L2 + MLX5DR_ACTION_HDR_LEN_L2_VLAN),

WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#2624: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_num_of_actions != num_of_actions'
#2695: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:73:
+	if ((cur_num_of_actions != num_of_actions) || (cur_type != type))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_type != type'
#2695: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:73:
+	if ((cur_num_of_actions != num_of_actions) || (cur_type != type))

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#2766: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:144:
+		if (cached_pattern->mh_data.pattern_obj->id == action->modify_header.pattern_obj->id)

CHECK:SPACING: No space is necessary after a cast
#2928: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:306:
+	mlx5dr_action_prepare_decap_l3_data(arg_data, (uint8_t *) wqe_arg,

ERROR:C99_COMMENTS: do not use C99 // comments
#2989: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:367:
+		memset(wqe_ctrl, 0, wqe_len); // TODO OPT: GTA ctrl might be ignored in case of arg

WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#3141: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates

total: 7 errors, 20 warnings, 5 checks, 3055 lines checked
Warning in drivers/net/mlx5/hws/mlx5dr_action.c:
Using rte_atomicNN_xxx