|WARNING| pw116682 [v1 19/19] net/mlx5/hws: Enable HWS

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 22 21:11:23 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116682

_coding style issues_


WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#168: FILE: drivers/net/mlx5/hws/mlx5dr.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#680: FILE: drivers/net/mlx5/hws/mlx5dr.h:514:
+ * ^ICopy the ASO object value into this reg_id, after a packet hits a rule with this ASO object.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#739: FILE: drivers/net/mlx5/hws/mlx5dr.h:573:
+ * ^IThe context to which the queue belong to.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#741: FILE: drivers/net/mlx5/hws/mlx5dr.h:575:
+ * ^IThe id of the queue to perform the action on.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#743: FILE: drivers/net/mlx5/hws/mlx5dr.h:577:
+ * ^IActions to perform on the queue. (enum mlx5dr_send_queue_actions)$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#755: FILE: drivers/net/mlx5/hws/mlx5dr.h:589:
+ * ^IThe file to write the dump to.$

WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#768: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_value' may be better as '(_value)' to avoid precedence issues
#812: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:46:
+#define IS_BIT_SET(_value, _bit) (_value & (1ULL << (_bit)))

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#824: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:58:
+	DRV_LOG(level, RTE_FMT("[%s]: " RTE_FMT_HEAD(__VA_ARGS__,), __func__, RTE_FMT_TAIL(__VA_ARGS__,)))

ERROR:SPACING: space required after that ',' (ctx:VxB)
#824: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:58:
+	DRV_LOG(level, RTE_FMT("[%s]: " RTE_FMT_HEAD(__VA_ARGS__,), __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 	                                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#824: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:58:
+	DRV_LOG(level, RTE_FMT("[%s]: " RTE_FMT_HEAD(__VA_ARGS__,), __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 	                                                                                              ^

total: 2 errors, 8 warnings, 1 checks, 740 lines checked


More information about the test-report mailing list