|WARNING| pw116757 [PATCH 22/27] net/mlx5: add HW steering VLAN push, pop and VID modify flow actions

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 23 16:48:32 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116757

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#403: FILE: drivers/net/mlx5/mlx5_flow_hw.c:2947:
+#define X_FIELD(ptr, t, f) ((t *)((ptr)->conf))->f

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#403: FILE: drivers/net/mlx5/mlx5_flow_hw.c:2947:
+#define X_FIELD(ptr, t, f) ((t *)((ptr)->conf))->f

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#403: FILE: drivers/net/mlx5/mlx5_flow_hw.c:2947:
+#define X_FIELD(ptr, t, f) ((t *)((ptr)->conf))->f

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#624: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3447:
+	for (i = 0; ra[i].type != RTE_FLOW_ACTION_TYPE_END; ++i) {
+			switch (ra[i].type) {

total: 1 errors, 1 warnings, 2 checks, 507 lines checked


More information about the test-report mailing list