|WARNING| pw129931 [PATCH] [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/129931

_apply patch failure_

Submitter: Julien Hascoet <jhascoet at kalrayinc.com>
Date: Monday, August 07 2023 06:18:43 
Applied on: CommitID:9836014d4c2b1b2c29948c928fd386b2944b6bcf
Apply patch set 129931 failed:

Checking patch app/test/test_mbuf.c...
error: while searching for:
               tref += ref;
               if ((ref & 1) != 0) {
                       rte_pktmbuf_refcnt_update(m, ref);
                       while (ref-- != 0)
                               rte_ring_enqueue(refcnt_mbuf_ring, m);
               } else {
                       while (ref-- != 0) {
                               rte_pktmbuf_refcnt_update(m, 1);
                               rte_ring_enqueue(refcnt_mbuf_ring, m);
                       }
               }
               rte_pktmbuf_free(m);

error: patch failed: app/test/test_mbuf.c:1033
Applying patch app/test/test_mbuf.c with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/app/test/test_mbuf.c b/app/test/test_mbuf.c	(rejected hunks)
@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,
                tref += ref;
                if ((ref & 1) != 0) {
                        rte_pktmbuf_refcnt_update(m, ref);
-                       while (ref-- != 0)
-                               rte_ring_enqueue(refcnt_mbuf_ring, m);
+                       while (ref-- != 0) {
+                               /* retry in case of failure */
+                               while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
+                                       ;
+                       }
                } else {
                        while (ref-- != 0) {
                                rte_pktmbuf_refcnt_update(m, 1);
-                               rte_ring_enqueue(refcnt_mbuf_ring, m);
+                               /* retry in case of failure */
+                               while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
+                                       ;
                        }
                }
                rte_pktmbuf_free(m);

https://lab.dpdk.org/results/dashboard/patchsets/27240/

UNH-IOL DPDK Community Lab