|WARNING| pw130161 [RFC v2] net/sfc: support packet replay in transfer flows

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 11 14:04:52 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/130161

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#173: FILE: drivers/common/sfc_efx/base/efx_mae.c:4286:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec_clone), spec_clone);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#190: FILE: drivers/common/sfc_efx/base/efx_mae.c:4303:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/common/sfc_efx/base/efx_mae.c:4307:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#218: FILE: drivers/common/sfc_efx/base/efx_mae.c:4331:
+	EFX_STATIC_ASSERT(sizeof (aset_list_idp->id) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#242: FILE: drivers/common/sfc_efx/base/efx_mae.c:4355:
+	    aset_ids, n_asets * sizeof (*aset_ids));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#265: FILE: drivers/common/sfc_efx/base/efx_mae.c:4378:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#277: FILE: drivers/common/sfc_efx/base/efx_mae.c:4390:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#335: FILE: drivers/common/sfc_efx/base/efx_mae.c:4448:
+	return (rc);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#490: FILE: drivers/net/sfc/sfc_mae.c:1344:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#504: FILE: drivers/net/sfc/sfc_mae.c:1358:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#782: FILE: drivers/net/sfc/sfc_mae.c:4512:
+					return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#835: FILE: drivers/net/sfc/sfc_mae.c:4717:
+		return ENOSPC;

total: 5 errors, 7 warnings, 0 checks, 1320 lines checked


More information about the test-report mailing list