|WARNING| pw121509 [PATCH 5/6] app/dumpcap: improve per interface arg parsing

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121509

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#82: 
This change improves the argument parsing to align closer to that of Wireshark

ERROR:C99_COMMENTS: do not use C99 // comments
#127: FILE: app/dumpcap/main.c:79:
+//TODO this can be specified per interface but there are a few places

ERROR:C99_COMMENTS: do not use C99 // comments
#128: FILE: app/dumpcap/main.c:80:
+// that need more review and possibly refactoring so leaving this one out

ERROR:C99_COMMENTS: do not use C99 // comments
#283: FILE: app/dumpcap/main.c:360:
+		// pcap = pcap_open_dead(DLT_EN10MB, intf->start_opts->snaplen);

ERROR:SPACING: space prohibited before that close parenthesis ')'
#325: FILE: app/dumpcap/main.c:451:
+			if (interface_arg_count == 0 )

ERROR:C99_COMMENTS: do not use C99 // comments
#338: FILE: app/dumpcap/main.c:466:
+			// set interface to global parameters when new interface is configured

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#343: FILE: app/dumpcap/main.c:471:
+			// interface_args[interface_arg_count - 1].snaplen = interface_defaults.snaplen;

ERROR:C99_COMMENTS: do not use C99 // comments
#343: FILE: app/dumpcap/main.c:471:
+			// interface_args[interface_arg_count - 1].snaplen = interface_defaults.snaplen;

ERROR:SPACING: space prohibited before that close parenthesis ')'
#352: FILE: app/dumpcap/main.c:480:
+			if (interface_arg_count == 0 )

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#364: FILE: app/dumpcap/main.c:494:
+			/*
+			if (interface_arg_count == 0 )

WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns
#367: FILE: app/dumpcap/main.c:497:
+				interface_args[interface_arg_count - 1].snaplen = get_uint(optarg, "snap_len", 0);

ERROR:C99_COMMENTS: do not use C99 // comments
#394: FILE: app/dumpcap/main.c:807:
+					   // flags, intf->start_opts->snaplen,

total: 8 errors, 4 warnings, 325 lines checked