|WARNING| pw121505 [PATCH 1/6] app/dumpcap: add additional dump info

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jan 2 17:26:52 CET 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121505

_coding style issues_


WARNING:BRACES: braces {} are not necessary for any arm of this statement
#115: FILE: app/dumpcap/main.c:279:
+		if (rte_eth_link_get_nowait(p, &link_info) < 0) {
[...]
+		else if (link_info.link_status == RTE_ETH_LINK_UP) {
[...]
+		else {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#118: FILE: app/dumpcap/main.c:282:
+		}
+		else if (link_info.link_status == RTE_ETH_LINK_UP) {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#121: FILE: app/dumpcap/main.c:285:
+		}
+		else {

ERROR:C99_COMMENTS: do not use C99 // comments
#125: FILE: app/dumpcap/main.c:289:
+		// not checking error here; should only error if given an invalid port id

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#126: FILE: app/dumpcap/main.c:290:
+		if (rte_eth_promiscuous_get(p) == 1) {
[...]
+		else {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#129: FILE: app/dumpcap/main.c:293:
+		}
+		else {

total: 4 errors, 2 warnings, 58 lines checked


More information about the test-report mailing list