|WARNING| pw129196 [v2 2/5] app/testpmd: support indirect actions list syntax

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jul 3 11:22:29 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/129196

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: app/test-pmd/cmdline_flow.c:7330:
+^I^I^I^I           rte_flow_action_indirect_list)),$

ERROR:C99_COMMENTS: do not use C99 // comments
#341: FILE: app/test-pmd/cmdline_flow.c:7350:
+//		.comp = comp_none,

ERROR:C99_COMMENTS: do not use C99 // comments
#347: FILE: app/test-pmd/cmdline_flow.c:7356:
+//		.comp = comp_none,

ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: app/test-pmd/cmdline_flow.c:7893:
+        case INDIRECT_ACTION_FLOW_CONF:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: app/test-pmd/cmdline_flow.c:7893:
+        case INDIRECT_ACTION_FLOW_CONF:$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#382: FILE: app/test-pmd/cmdline_flow.c:11405:
+		    void __rte_unused *buf, unsigned int __rte_unused size)
 		                      ^

ERROR:CODE_INDENT: code indent should use tabs where possible
#403: FILE: app/test-pmd/cmdline_flow.c:11426:
+        action_conf->handle = (typeof(action_conf->handle))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#403: FILE: app/test-pmd/cmdline_flow.c:11426:
+        action_conf->handle = (typeof(action_conf->handle))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#501: FILE: app/test-pmd/cmdline_flow.c:12531:
+	if (indlst_conf)
+        printf("created indirect action list configuration %u
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#502: FILE: app/test-pmd/cmdline_flow.c:12532:
+        printf("created indirect action list configuration %u
",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#502: FILE: app/test-pmd/cmdline_flow.c:12532:
+        printf("created indirect action list configuration %u
",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#503: FILE: app/test-pmd/cmdline_flow.c:12533:
+               in->args.vc.attr.group);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#503: FILE: app/test-pmd/cmdline_flow.c:12533:
+               in->args.vc.attr.group);$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#504: FILE: app/test-pmd/cmdline_flow.c:12534:
+	else
+        printf("cannot create indirect action list configuration %u
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#505: FILE: app/test-pmd/cmdline_flow.c:12535:
+        printf("cannot create indirect action list configuration %u
",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#505: FILE: app/test-pmd/cmdline_flow.c:12535:
+        printf("cannot create indirect action list configuration %u
",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#506: FILE: app/test-pmd/cmdline_flow.c:12536:
+               in->args.vc.attr.group);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#506: FILE: app/test-pmd/cmdline_flow.c:12536:
+               in->args.vc.attr.group);$

total: 10 errors, 8 warnings, 411 lines checked


More information about the test-report mailing list