|WARNING| pw128501 [RFC] lib/ethdev: introduce table driven APIs

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jun 12 04:56:59 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128501

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#156: 
rte_flow_table_info_get_by_name(port_id, "decap_vxlan_tcp_table", &tbl_info);

WARNING:TYPO_SPELLING: 'destoried' may be misspelled - perhaps 'destroyed'?
#406: FILE: lib/ethdev/rte_flow_table.h:143:
+	int ref_cnt; /**< Reference count, in async ops it prevents the object be destoried .*/

WARNING:TYPO_SPELLING: 'destoried' may be misspelled - perhaps 'destroyed'?
#422: FILE: lib/ethdev/rte_flow_table.h:159:
+	int ref_cnt; /**< Reference count, in async ops it prevents the object be destoried .*/

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#495: FILE: lib/ethdev/rte_flow_table.h:232:
+ * @warning
+* @b EXPERIMENTAL: this API may change without prior notice.

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#496: FILE: lib/ethdev/rte_flow_table.h:233:
+* @b EXPERIMENTAL: this API may change without prior notice.
+ *

ERROR:CODE_INDENT: code indent should use tabs where possible
#906: FILE: lib/ethdev/rte_flow_table.h:643:
+^I^I^I^I        struct rte_flow_table_key *key,$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#963: FILE: lib/ethdev/rte_flow_table.h:700:
+ * @param[in] prefix $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#991: FILE: lib/ethdev/rte_flow_table.h:728:
+ * @param[in] name $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#997: FILE: lib/ethdev/rte_flow_table.h:734:
+ * @param[in] prefix $

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#1009: FILE: lib/ethdev/rte_flow_table.h:746:
+						 const char* name,

WARNING:TYPO_SPELLING: 'indiates' may be misspelled - perhaps 'indicates'?
#1435: FILE: lib/ethdev/rte_flow_table.h:1172:
+ *    >=0 on success, indiates the number of status be pulled.

WARNING:TYPO_SPELLING: 'identifer' may be misspelled - perhaps 'identifier'?
#1473: FILE: lib/ethdev/rte_flow_table.h:1210:
+ * Get a PNA queue identifer from a ethdev Rx queue.

WARNING:TYPO_SPELLING: 'identifer' may be misspelled - perhaps 'identifier'?
#1501: FILE: lib/ethdev/rte_flow_table.h:1238:
+ * Get a PNA queue identifer from a ethdev Tx queue.

total: 5 errors, 8 warnings, 1261 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.


More information about the test-report mailing list