|WARNING| pw128506 [PATCH v5] gro : ipv6 changes to support GRO for TCP/ipv6

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jun 12 13:06:44 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128506

_coding style issues_


WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#325: FILE: lib/gro/gro_tcp4.c:191:
+		item_idx = insert_new_tcp_item(pkt, tbl->items, &tbl->item_num, tbl->max_item_num, start_time,

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#404: FILE: lib/gro/gro_tcp4.c:252:
+				j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);

WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#813: FILE: lib/gro/gro_tcp6.c:193:
+		item_idx = insert_new_tcp_item(pkt, tbl->items, &tbl->item_num, tbl->max_item_num, start_time,

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#822: FILE: lib/gro/gro_tcp6.c:202:
+			 * stored packet.
+			*/

ERROR:TRAILING_WHITESPACE: trailing whitespace
#830: FILE: lib/gro/gro_tcp6.c:210:
+^I^I^I^I^I^I&tbl->item_num, tbl->max_item_num, $

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#858: FILE: lib/gro/gro_tcp6.c:238:
+				j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1037: FILE: lib/gro/gro_tcp6.h:146:
+	if (memcmp(&k1->src_addr, &k2->src_addr, 16)) {
+		return 0;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1040: FILE: lib/gro/gro_tcp6.h:149:
+	if (memcmp(&k1->dst_addr, &k2->dst_addr, 16)) {
+		return 0;
+	}

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1044: FILE: lib/gro/gro_tcp6.h:153:
+	/*
+	* IP version (4) Traffic Class (8) Flow Label (20)

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1172: FILE: lib/gro/gro_tcp_internal.c:112:
+			if (insert_new_tcp_item(pkt, items, item_num, max_item_num, start_time, cur_idx,

total: 1 errors, 9 warnings, 1506 lines checked


More information about the test-report mailing list