|WARNING| pw128908 [PATCH v6 2/4] common/sfc_efx/base: add API to get installed filters count

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 22 13:33:40 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128908

_coding style issues_


ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#89: FILE: drivers/common/sfc_efx/base/ef10_filter.c:2133:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#147: FILE: drivers/common/sfc_efx/base/efx_filter.c:315:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#162: FILE: drivers/common/sfc_efx/base/efx_filter.c:330:
+		if ((rc = enp->en_efop->efo_get_count(enp, count)) != 0)

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#179: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+	efx_rc_t	(*efo_get_count)(efx_nic_t *, uint32_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#179: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+	efx_rc_t	(*efo_get_count)(efx_nic_t *, uint32_t *);

total: 3 errors, 2 warnings, 108 lines checked


More information about the test-report mailing list