|WARNING| pw126947 [PATCH] lib/cryptodev: move RSA padding information into xform

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/126947

_apply patch failure_

Submitter: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
Date: Wednesday, May 17 2023 16:52:41 
Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c
Apply patch set 126947 failed:

Checking patch app/test/test_cryptodev_asym.c...
error: while searching for:
	asym_op->rsa.message.length = rsaplaintext.len;
	asym_op->rsa.sign.length = RTE_DIM(rsa_n);
	asym_op->rsa.sign.data = output_buf;
	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;

	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
		      asym_op->rsa.message.length);

error: patch failed: app/test/test_cryptodev_asym.c:92
Hunk #2 succeeded at 124 (offset 1 line).
error: while searching for:
	asym_op->rsa.cipher.data = cipher_buf;
	asym_op->rsa.cipher.length = RTE_DIM(rsa_n);
	asym_op->rsa.message.length = rsaplaintext.len;
	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;

	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
		      asym_op->rsa.message.length);

error: patch failed: app/test/test_cryptodev_asym.c:183
error: while searching for:
	asym_op = result_op->asym;
	asym_op->rsa.message.length = RTE_DIM(rsa_n);
	asym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;
	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;

	/* Process crypto operation */
	if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {

error: patch failed: app/test/test_cryptodev_asym.c:215
Hunk #5 succeeded at 411 (offset 3 lines).
Checking patch app/test/test_cryptodev_rsa_test_vectors.h...
Checking patch drivers/common/cpt/cpt_ucode_asym.h...
Checking patch drivers/crypto/cnxk/cnxk_ae.h...
Checking patch drivers/crypto/octeontx/otx_cryptodev_ops.c...
Checking patch drivers/crypto/openssl/openssl_pmd_private.h...
Checking patch drivers/crypto/openssl/rte_openssl_pmd.c...
Checking patch drivers/crypto/openssl/rte_openssl_pmd_ops.c...
Checking patch drivers/crypto/qat/qat_asym.c...
Checking patch examples/fips_validation/main.c...
Checking patch lib/cryptodev/rte_crypto_asym.h...
error: while searching for:
	 * This could be validated and overwritten by the PMD
	 * with the signature length.
	 */

	struct rte_crypto_rsa_padding padding;
	/**< RSA padding information */
};

/**

error: patch failed: lib/cryptodev/rte_crypto_asym.h:451
Applying patch app/test/test_cryptodev_asym.c with 3 rejects...
Rejected hunk #1.
Hunk #2 applied cleanly.
Rejected hunk #3.
Rejected hunk #4.
Hunk #5 applied cleanly.
Applied patch app/test/test_cryptodev_rsa_test_vectors.h cleanly.
Applied patch drivers/common/cpt/cpt_ucode_asym.h cleanly.
Applied patch drivers/crypto/cnxk/cnxk_ae.h cleanly.
Applied patch drivers/crypto/octeontx/otx_cryptodev_ops.c cleanly.
Applied patch drivers/crypto/openssl/openssl_pmd_private.h cleanly.
Applied patch drivers/crypto/openssl/rte_openssl_pmd.c cleanly.
Applied patch drivers/crypto/openssl/rte_openssl_pmd_ops.c cleanly.
Applied patch drivers/crypto/qat/qat_asym.c cleanly.
Applied patch examples/fips_validation/main.c cleanly.
Applying patch lib/cryptodev/rte_crypto_asym.h with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c	(rejected hunks)
@@ -92,7 +92,6 @@ queue_ops_rsa_sign_verify(void *sess)
 	asym_op->rsa.message.length = rsaplaintext.len;
 	asym_op->rsa.sign.length = RTE_DIM(rsa_n);
 	asym_op->rsa.sign.data = output_buf;
-	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;
 
 	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
 		      asym_op->rsa.message.length);
@@ -183,7 +181,6 @@ queue_ops_rsa_enc_dec(void *sess)
 	asym_op->rsa.cipher.data = cipher_buf;
 	asym_op->rsa.cipher.length = RTE_DIM(rsa_n);
 	asym_op->rsa.message.length = rsaplaintext.len;
-	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;
 
 	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
 		      asym_op->rsa.message.length);
@@ -215,7 +212,6 @@ queue_ops_rsa_enc_dec(void *sess)
 	asym_op = result_op->asym;
 	asym_op->rsa.message.length = RTE_DIM(rsa_n);
 	asym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;
-	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;
 
 	/* Process crypto operation */
 	if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {
diff a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h	(rejected hunks)
@@ -451,9 +454,6 @@ struct rte_crypto_rsa_op_param {
 	 * This could be validated and overwritten by the PMD
 	 * with the signature length.
 	 */
-
-	struct rte_crypto_rsa_padding padding;
-	/**< RSA padding information */
 };
 
 /**

https://lab.dpdk.org/results/dashboard/patchsets/26264/

UNH-IOL DPDK Community Lab