|WARNING| pw126962 [PATCH] drivers/net/bnx2x : Add experimental 2.5Gbps support for BCM578xx.

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/126962

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
This has been tested with GPON's ONU SFP but requires a specific firmware configuration.

WARNING:TYPO_SPELLING: 'advertisment' may be misspelled - perhaps 'advertisement'?
#102: FILE: drivers/net/bnx2x/elink.c:5073:
+        /* Note that 2.5G works only when used with 1G advertisment */

ERROR:CODE_INDENT: code indent should use tabs where possible
#102: FILE: drivers/net/bnx2x/elink.c:5073:
+        /* Note that 2.5G works only when used with 1G advertisment */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+                if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+                if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+                if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&
[...]
+                    elink_cl45_write(sc, phy, MDIO_WC_DEVAD,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->req_line_speed == SPEED_2500'
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+                if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&
+                   (phy->speed_cap_mask &
+                   (PORT_HW_CFG_SPEED_CAPABILITY_D0_1G |
+                    PORT_HW_CFG_SPEED_CAPABILITY_D0_2_5G))) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#104: FILE: drivers/net/bnx2x/elink.c:5075:
+                   (phy->speed_cap_mask &$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#104: FILE: drivers/net/bnx2x/elink.c:5075:
+                   (phy->speed_cap_mask &$

ERROR:CODE_INDENT: code indent should use tabs where possible
#105: FILE: drivers/net/bnx2x/elink.c:5076:
+                   (PORT_HW_CFG_SPEED_CAPABILITY_D0_1G |$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/net/bnx2x/elink.c:5076:
+                   (PORT_HW_CFG_SPEED_CAPABILITY_D0_1G |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#106: FILE: drivers/net/bnx2x/elink.c:5077:
+                    PORT_HW_CFG_SPEED_CAPABILITY_D0_2_5G))) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#106: FILE: drivers/net/bnx2x/elink.c:5077:
+                    PORT_HW_CFG_SPEED_CAPABILITY_D0_2_5G))) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#107: FILE: drivers/net/bnx2x/elink.c:5078:
+                    elink_cl45_write(sc, phy, MDIO_WC_DEVAD,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: drivers/net/bnx2x/elink.c:5078:
+                    elink_cl45_write(sc, phy, MDIO_WC_DEVAD,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#108: FILE: drivers/net/bnx2x/elink.c:5079:
+                    MDIO_WC_REG_SERDESDIGITAL_MISC1,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: drivers/net/bnx2x/elink.c:5079:
+                    MDIO_WC_REG_SERDESDIGITAL_MISC1,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#109: FILE: drivers/net/bnx2x/elink.c:5080:
+                        0x6010);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: drivers/net/bnx2x/elink.c:5080:
+                        0x6010);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: drivers/net/bnx2x/elink.c:5081:
+                 }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: drivers/net/bnx2x/elink.c:5081:
+                 }$

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->req_line_speed != ELINK_SPEED_1000'
#136: FILE: drivers/net/bnx2x/elink.c:9167:
+			if ((phy->req_line_speed != ELINK_SPEED_1000) &&
+                            (phy->req_line_speed != ELINK_SPEED_2500)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->req_line_speed != ELINK_SPEED_2500'
#136: FILE: drivers/net/bnx2x/elink.c:9167:
+			if ((phy->req_line_speed != ELINK_SPEED_1000) &&
+                            (phy->req_line_speed != ELINK_SPEED_2500)) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: drivers/net/bnx2x/elink.c:9168:
+                            (phy->req_line_speed != ELINK_SPEED_2500)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: drivers/net/bnx2x/elink.c:9168:
+                            (phy->req_line_speed != ELINK_SPEED_2500)) {$

CHECK:CAMELCASE: Avoid CamelCase: <ELINK_SUPPORTED_2500baseX_Full>
#154: FILE: drivers/net/bnx2x/elink.c:12631:
+			   ELINK_SUPPORTED_2500baseX_Full |

total: 10 errors, 12 warnings, 4 checks, 84 lines checked