|WARNING| pw132651 [PATCH v2 15/16] net/mlx5: support indirect list METER_MARK action

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Oct 16 20:47:18 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/132651

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#165: FILE: drivers/net/mlx5/mlx5_flow.c:1187:
+						rte_flow_action_list_handle *handle,
 						                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#211: FILE: drivers/net/mlx5/mlx5_flow.c:11052:
+						rte_flow_action_list_handle *handle,
 						                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#265: FILE: drivers/net/mlx5/mlx5_flow.h:119:
+	LIST_HEAD(, mlx5_indirect_list) *h = head;
 	                                ^

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#276: FILE: drivers/net/mlx5/mlx5_flow.h:130:
+
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'priv' - possible side-effects?
#364: FILE: drivers/net/mlx5/mlx5_flow_hw.c:64:
+#define MLX5_HW_PORT_IS_PROXY(priv) \
+	(!!((priv)->sh->esw_mode && (priv)->master))

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#365: FILE: drivers/net/mlx5/mlx5_flow_hw.c:65:
+	(!!((priv)->sh->esw_mode && (priv)->master))

CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#515: FILE: drivers/net/mlx5/mlx5_flow_hw.c:1547:
+			rte_flow_indirect_update_flow_meter_mark **flow_conf =
 			                                         ^

total: 0 errors, 2 warnings, 6 checks, 804 lines checked


More information about the test-report mailing list