|WARNING| pw133683 [PATCH 1/3] net/tap: support infrastructure to build the BPF filter

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/133683

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#209: FILE: drivers/net/tap/bpf/bpf_api.h:31:
+#define __uint(name, val) int (*name)[val]

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#210: FILE: drivers/net/tap/bpf/bpf_api.h:32:
+#define __type(name, val) typeof(val) *name

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#210: FILE: drivers/net/tap/bpf/bpf_api.h:32:
+#define __type(name, val) typeof(val) *name

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#211: FILE: drivers/net/tap/bpf/bpf_api.h:33:
+#define __array(name, val) typeof(val) *name[]

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#211: FILE: drivers/net/tap/bpf/bpf_api.h:33:
+#define __array(name, val) typeof(val) *name[]

WARNING:CONSTANT_CONVERSION: __constant_htons should be htons
#236: FILE: drivers/net/tap/bpf/bpf_api.h:58:
+# define htons(X)		__constant_htons((X))

WARNING:CONSTANT_CONVERSION: __constant_ntohs should be ntohs
#240: FILE: drivers/net/tap/bpf/bpf_api.h:62:
+# define ntohs(X)		__constant_ntohs((X))

WARNING:INLINE: plain inline is preferred over __inline__
#251: FILE: drivers/net/tap/bpf/bpf_api.h:73:
+#ifndef __inline__

WARNING:INLINE: plain inline is preferred over __inline__
#252: FILE: drivers/net/tap/bpf/bpf_api.h:74:
+# define __inline__		__attribute__((always_inline))

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#313: FILE: drivers/net/tap/bpf/bpf_api.h:135:
+# define __BPF_FUNC(NAME, ...)						\
+	(* NAME)(__VA_ARGS__) __maybe_unused

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'NAME' may be better as '(NAME)' to avoid precedence issues
#313: FILE: drivers/net/tap/bpf/bpf_api.h:135:
+# define __BPF_FUNC(NAME, ...)						\
+	(* NAME)(__VA_ARGS__) __maybe_unused

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#318: FILE: drivers/net/tap/bpf/bpf_api.h:140:
+# define BPF_FUNC(NAME, ...)						\
+	__BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME

CHECK:SPACING: No space is necessary after a cast
#319: FILE: drivers/net/tap/bpf/bpf_api.h:141:
+	__BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME

WARNING:TRACE_PRINTK: Do not use trace_printk() in production code (this can be ignored if built only with a debug config option)
#344: FILE: drivers/net/tap/bpf/bpf_api.h:166:
+		trace_printk(____fmt, sizeof(____fmt), ##__VA_ARGS__);	\

CHECK:SPACING: No space is necessary after a cast
#397: FILE: drivers/net/tap/bpf/bpf_api.h:219:
+		      (void *) BPF_FUNC_perf_event_output;

CHECK:SPACING: No space is necessary after a cast
#419: FILE: drivers/net/tap/bpf/bpf_api.h:241:
+# define lock_xadd(ptr, val)	((void) __sync_fetch_and_add(ptr, val))

WARNING:TYPO_SPELLING: 'useable' may be misspelled - perhaps 'usable'?
#434: FILE: drivers/net/tap/bpf/bpf_api.h:256:
+/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#438: FILE: drivers/net/tap/bpf/bpf_api.h:260:
+#if 0

WARNING:PREFER_SECTION: __section(.maps.) is preferred over __attribute__((section(".maps.")))
#509: FILE: drivers/net/tap/bpf/bpf_elf.h:50:
+	    __attribute__ ((section(".maps." #name), used))	\

total: 4 errors, 8 warnings, 7 checks, 481 lines checked
Warning in drivers/net/tap/bpf/bpf_api.h:
Using compiler attribute directly
Warning in drivers/net/tap/bpf/bpf_api.h:
Using __sync_xxx builtins