|WARNING| pw139066 [PATCH] vhost: fix crash caused by accessing a freed vsocket

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139066

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/vhost/fd_man.c:254:
+               vhost_thread_read_lock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: lib/vhost/fd_man.c:254:
+               vhost_thread_read_lock();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/vhost/fd_man.c:308:
+               vhost_thread_read_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/vhost/fd_man.c:308:
+               vhost_thread_read_unlock();$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#194: FILE: lib/vhost/socket.c:466:
         while (1) {
+               vhost_thread_read_lock();

ERROR:CODE_INDENT: code indent should use tabs where possible
#195: FILE: lib/vhost/socket.c:467:
+               vhost_thread_read_lock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: lib/vhost/socket.c:467:
+               vhost_thread_read_lock();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#203: FILE: lib/vhost/socket.c:499:
+               vhost_thread_read_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: lib/vhost/socket.c:499:
+               vhost_thread_read_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#212: FILE: lib/vhost/socket.c:1077:
+       vhost_thread_write_lock();$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#218: FILE: lib/vhost/socket.c:1087:
                 } else if (vsocket->is_server) {
[...]
+                       fdset_del(&vhost_user.fdset, vsocket->socket_fd);

ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: lib/vhost/socket.c:1089:
+                        * The vhost thread write lock has been acquired,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: lib/vhost/socket.c:1090:
+                        * and fd must be deleted from fdset.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: lib/vhost/socket.c:1092:
+                       fdset_del(&vhost_user.fdset, vsocket->socket_fd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: lib/vhost/socket.c:1092:
+                       fdset_del(&vhost_user.fdset, vsocket->socket_fd);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#242: FILE: lib/vhost/socket.c:1104:
+                        * The vhost thread write lock has been acquired,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#243: FILE: lib/vhost/socket.c:1105:
+                        * and fd must be deleted from fdset.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#251: FILE: lib/vhost/socket.c:1107:
+                       fdset_del(&vhost_user.fdset, conn->connfd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: lib/vhost/socket.c:1107:
+                       fdset_del(&vhost_user.fdset, conn->connfd);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#259: FILE: lib/vhost/socket.c:1129:
+               vhost_thread_write_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#259: FILE: lib/vhost/socket.c:1129:
+               vhost_thread_write_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: lib/vhost/socket.c:1133:
+       vhost_thread_write_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: lib/vhost/vhost_thread.c:14:
+       rte_rwlock_read_lock(&vhost_thread_lock);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#292: FILE: lib/vhost/vhost_thread.c:20:
+       rte_rwlock_read_unlock(&vhost_thread_lock);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: lib/vhost/vhost_thread.c:26:
+       rte_rwlock_write_lock(&vhost_thread_lock);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: lib/vhost/vhost_thread.c:32:
+       rte_rwlock_write_unlock(&vhost_thread_lock);$

total: 11 errors, 15 warnings, 154 lines checked