|WARNING| pw139608 [PATCH] eal/linux: enhanced error handling for affinity

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Apr 22 15:51:18 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139608

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#166: FILE: lib/eal/unix/rte_thread.c:119:
+static void cpuset_to_string(const cpu_set_t *cpuset,
+			char *cpus_str, size_t cpus_str_size) {

ERROR:C99_COMMENTS: do not use C99 // comments
#169: FILE: lib/eal/unix/rte_thread.c:122:
+	// Track the current position in the string

ERROR:C99_COMMENTS: do not use C99 // comments
#172: FILE: lib/eal/unix/rte_thread.c:125:
+	// Clear the string buffer

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#174: FILE: lib/eal/unix/rte_thread.c:127:
+	cpus_str_size = RTE_MAX_LCORE < cpus_str_size ?

ERROR:C99_COMMENTS: do not use C99 // comments
#177: FILE: lib/eal/unix/rte_thread.c:130:
+	// Iterate over each CPU core, and check if it is included in the set

ERROR:C99_COMMENTS: do not use C99 // comments
#180: FILE: lib/eal/unix/rte_thread.c:133:
+			// Append the current CPU number to the string

ERROR:C99_COMMENTS: do not use C99 // comments
#190: FILE: lib/eal/unix/rte_thread.c:143:
+	// Ensure the string is properly terminated

total: 6 errors, 1 warnings, 76 lines checked


More information about the test-report mailing list