|WARNING| pw143024 [PATCH 1/4] [v1, 1/4] zsda: Introduce zsda device drivers

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Aug 8 11:03:06 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143024

_coding style issues_


WARNING:TYPO_SPELLING: 'BTYE' may be misspelled - perhaps 'BYTE'?
#396: FILE: drivers/common/zsda/zsda_common.h:78:
+#define ZSDA_64_BTYE_ALIGN_MASK (~0x3f)

ERROR:C99_COMMENTS: do not use C99 // comments
#426: FILE: drivers/common/zsda/zsda_common.h:108:
+#define ZSDA_OPC_COMP_GZIP	0x10 // Encomp deflate-Gzip

ERROR:C99_COMMENTS: do not use C99 // comments
#427: FILE: drivers/common/zsda/zsda_common.h:109:
+#define ZSDA_OPC_COMP_ZLIB	0x11 // Encomp deflate-Zlib

ERROR:C99_COMMENTS: do not use C99 // comments
#428: FILE: drivers/common/zsda/zsda_common.h:110:
+#define ZSDA_OPC_DECOMP_GZIP	0x18 // Decompinfalte-Gzip

ERROR:C99_COMMENTS: do not use C99 // comments
#429: FILE: drivers/common/zsda/zsda_common.h:111:
+#define ZSDA_OPC_DECOMP_ZLIB	0x19 // Decompinfalte-Zlib

WARNING:TYPO_SPELLING: 'elment' may be misspelled - perhaps 'element'?
#452: FILE: drivers/common/zsda/zsda_common.h:134:
+enum sgl_elment_type_wqe {

WARNING:TYPO_SPELLING: 'elment' may be misspelled - perhaps 'element'?
#459: FILE: drivers/common/zsda/zsda_common.h:141:
+enum sgl_elment_type {

ERROR:C99_COMMENTS: do not use C99 // comments
#467: FILE: drivers/common/zsda/zsda_common.h:149:
+	// Version information

ERROR:C99_COMMENTS: do not use C99 // comments
#470: FILE: drivers/common/zsda/zsda_common.h:152:
+	// algo type

ERROR:C99_COMMENTS: do not use C99 // comments
#473: FILE: drivers/common/zsda/zsda_common.h:155:
+	// get cycle

ERROR:C99_COMMENTS: do not use C99 // comments
#476: FILE: drivers/common/zsda/zsda_common.h:158:
+	// set cyclr

ERROR:C99_COMMENTS: do not use C99 // comments
#482: FILE: drivers/common/zsda/zsda_common.h:164:
+	// set close flr register

ERROR:C99_COMMENTS: do not use C99 // comments
#579: FILE: drivers/common/zsda/zsda_common.h:261:
+	uint8_t valid; // cqe_cycle

total: 10 errors, 3 warnings, 602 lines checked
Warning in drivers/common/zsda/zsda_logs.h:
Do not use variadic argument pack in macros
Warning in drivers/common/zsda/zsda_logs.c:
Using RTE_LOG_REGISTER, prefer RTE_LOG_REGISTER_(DEFAULT|SUFFIX)
Please use __rte_cache_aligned only for struct or union types alignment.


More information about the test-report mailing list