|WARNING| pw136535 [PATCH v2] net/netvsc: fix parsing of VLAN metadata

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Feb 8 15:43:06 CET 2024
Previous message (by thread): |SUCCESS| dpdk-next-net| ee647455f0| Intel-compilation
Next message (by thread): |WARNING| pw136535 [PATCH v2] net/netvsc: fix parsing of VLAN metadata
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136535

_coding style issues_


ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#137: FILE: .mailmap:32:
Alan Brady <alan.brady at intel.com>

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#153: FILE: drivers/net/netvsc/hn_rxtx.c:44:
+#define HN_VLAN_CFI_MASK               0x1000 /* Canonical Format Indicator / Drop Eligible Indicator */

ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/net/netvsc/hn_rxtx.c:47:
+             struct ndis_pkt_vlan_info vlan_info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: drivers/net/netvsc/hn_rxtx.c:47:
+             struct ndis_pkt_vlan_info vlan_info;$

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#167: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+                                             info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);

ERROR:CODE_INDENT: code indent should use tabs where possible
#167: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+                                             info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#167: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+                                             info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#175: FILE: drivers/net/netvsc/hn_rxtx.c:618:
+             if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#175: FILE: drivers/net/netvsc/hn_rxtx.c:618:
+             if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (13, 29)
#175: FILE: drivers/net/netvsc/hn_rxtx.c:618:
+             if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {
+                             m->vlan_tci = info->vlan_info.vlanid |

ERROR:CODE_INDENT: code indent should use tabs where possible
#176: FILE: drivers/net/netvsc/hn_rxtx.c:619:
+                             m->vlan_tci = info->vlan_info.vlanid |$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#176: FILE: drivers/net/netvsc/hn_rxtx.c:619:
+                             m->vlan_tci = info->vlan_info.vlanid |$

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#177: FILE: drivers/net/netvsc/hn_rxtx.c:620:
+                                                             (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |

ERROR:CODE_INDENT: code indent should use tabs where possible
#177: FILE: drivers/net/netvsc/hn_rxtx.c:620:
+                                                             (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#177: FILE: drivers/net/netvsc/hn_rxtx.c:620:
+                                                             (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#178: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+                                                             (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);

ERROR:CODE_INDENT: code indent should use tabs where possible
#178: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+                                                             (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+                                                             (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: drivers/net/netvsc/hn_rxtx.c:679:
+                             .vlan_info.value = HN_NDIS_VLAN_INFO_INVALID,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: drivers/net/netvsc/hn_rxtx.c:679:
+                             .vlan_info.value = HN_NDIS_VLAN_INFO_INVALID,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#195: FILE: drivers/net/netvsc/hn_rxtx.c:1342:
+                             struct ndis_pkt_vlan_info *vlan = (struct ndis_pkt_vlan_info *)pi_data;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: drivers/net/netvsc/hn_rxtx.c:1342:
+                             struct ndis_pkt_vlan_info *vlan = (struct ndis_pkt_vlan_info *)pi_data;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#196: FILE: drivers/net/netvsc/hn_rxtx.c:1343:
+                             vlan->value = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: drivers/net/netvsc/hn_rxtx.c:1343:
+                             vlan->value = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#197: FILE: drivers/net/netvsc/hn_rxtx.c:1344:
+                             vlan->vlanid = (m->vlan_tci & HN_VLAN_VID_MASK);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: drivers/net/netvsc/hn_rxtx.c:1344:
+                             vlan->vlanid = (m->vlan_tci & HN_VLAN_VID_MASK);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#198: FILE: drivers/net/netvsc/hn_rxtx.c:1345:
+                             vlan->cfi = (!!(m->vlan_tci & HN_VLAN_CFI_MASK));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: drivers/net/netvsc/hn_rxtx.c:1345:
+                             vlan->cfi = (!!(m->vlan_tci & HN_VLAN_CFI_MASK));$

ERROR:CODE_INDENT: code indent should use tabs where possible
#199: FILE: drivers/net/netvsc/hn_rxtx.c:1346:
+                             vlan->pri = ((m->vlan_tci & HN_VLAN_PRIO_MASK) >> HN_VLAN_PRIO_SHIFT);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: drivers/net/netvsc/hn_rxtx.c:1346:
+                             vlan->pri = ((m->vlan_tci & HN_VLAN_PRIO_MASK) >> HN_VLAN_PRIO_SHIFT);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#220: FILE: drivers/net/netvsc/ndis.h:319:
+             union {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: drivers/net/netvsc/ndis.h:319:
+             union {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#221: FILE: drivers/net/netvsc/ndis.h:320:
+                             struct {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: drivers/net/netvsc/ndis.h:320:
+                             struct {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: drivers/net/netvsc/ndis.h:321:
+                                             uint32_t pri:3; /* User Priority */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: drivers/net/netvsc/ndis.h:321:
+                                             uint32_t pri:3; /* User Priority */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: drivers/net/netvsc/ndis.h:322:
+                                             uint32_t cfi:1; /* Canonical Format ID / DEI */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: drivers/net/netvsc/ndis.h:322:
+                                             uint32_t cfi:1; /* Canonical Format ID / DEI */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: drivers/net/netvsc/ndis.h:323:
+                                             uint32_t vlanid:12; /* VLAN ID */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: drivers/net/netvsc/ndis.h:323:
+                                             uint32_t vlanid:12; /* VLAN ID */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#225: FILE: drivers/net/netvsc/ndis.h:324:
+                                             uint32_t reserved:16;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#225: FILE: drivers/net/netvsc/ndis.h:324:
+                                             uint32_t reserved:16;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#226: FILE: drivers/net/netvsc/ndis.h:325:
+                             };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: drivers/net/netvsc/ndis.h:325:
+                             };$

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: drivers/net/netvsc/ndis.h:326:
+                             uint32_t value;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: drivers/net/netvsc/ndis.h:326:
+                             uint32_t value;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: drivers/net/netvsc/ndis.h:327:
+             };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: drivers/net/netvsc/ndis.h:327:
+             };$

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#231: FILE: drivers/net/netvsc/ndis.h:330:
+#define             NDIS_VLAN_INFO_SIZE                              sizeof(struct ndis_pkt_vlan_info)

total: 22 errors, 27 warnings, 0 checks, 90 lines checked
Previous message (by thread): |SUCCESS| dpdk-next-net| ee647455f0| Intel-compilation
Next message (by thread): |WARNING| pw136535 [PATCH v2] net/netvsc: fix parsing of VLAN metadata
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list