|WARNING| pw136846 [PATCH v2 3/3] add extension keyword to GCC statement expressions

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136846

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#248: FILE: drivers/crypto/caam_jr/caam_jr_desc.h:35:
+#define SEC_JD_INIT(descriptor)	      __extension__ ({ \
 	/* CTYPE = job descriptor			       \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#274: FILE: drivers/event/octeontx/ssovf_evdev.h:99:
+#define ssovf_load_pair(val0, val1, addr) __extension__ ({		\
 			asm volatile(			\
 			"ldp %x[x0], %x[x1], [%x[p1]]"	\
 			:[x0]"=r"(val0), [x1]"=r"(val1) \
 			:[p1]"r"(addr)			\
 			); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#282: FILE: drivers/event/octeontx/ssovf_evdev.h:106:
+#define ssovf_store_pair(val0, val1, addr) __extension__ ({		\
 			asm volatile(			\
 			"stp %x[x0], %x[x1], [%x[p1]]"	\
 			::[x0]"r"(val0), [x1]"r"(val1), [p1]"r"(addr) \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#295: FILE: drivers/mempool/octeontx/octeontx_fpavf.h:62:
+#define fpavf_load_pair(val0, val1, addr) __extension__ ({		\
 			asm volatile(			\
 			"ldp %x[x0], %x[x1], [%x[p1]]"	\
 			:[x0]"=r"(val0), [x1]"=r"(val1) \
 			:[p1]"r"(addr)			\
 			); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#303: FILE: drivers/mempool/octeontx/octeontx_fpavf.h:69:
+#define fpavf_store_pair(val0, val1, addr) __extension__ ({		\
 			asm volatile(			\
 			"stp %x[x0], %x[x1], [%x[p1]]"	\
 			::[x0]"r"(val0), [x1]"r"(val1), [p1]"r"(addr) \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#317: FILE: drivers/ml/cnxk/cn10k_ml_dev.h:47:
+#define dmb_st __extension__ ({ asm volatile("dmb st" : : : "memory"); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#318: FILE: drivers/ml/cnxk/cn10k_ml_dev.h:48:
+#define dsb_st __extension__ ({ asm volatile("dsb st" : : : "memory"); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#501: FILE: drivers/net/enetfec/enet_ethdev.h:45:
+#define writel(v, p) __extension__ ({*(volatile unsigned int *)(p) = (v); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#514: FILE: drivers/net/fm10k/base/fm10k_osdep.h:105:
+#define do_div(n, base) __extension__ ({\
 	(n) = (n) / (base);\
 })

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#514: FILE: drivers/net/fm10k/base/fm10k_osdep.h:105:
+#define do_div(n, base) __extension__ ({\
 	(n) = (n) / (base);\
 })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#527: FILE: drivers/net/octeontx/base/octeontx_io.h:22:
+#define octeontx_prefetch_store_keep(_ptr) __extension__ ({\
 	asm volatile("prfm pstl1keep, %a0
" : : "p" (_ptr)); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#531: FILE: drivers/net/octeontx/base/octeontx_io.h:25:
+#define octeontx_load_pair(val0, val1, addr) __extension__ ({		\
 			asm volatile(			\
 			"ldp %x[x0], %x[x1], [%x[p1]]"	\
 			:[x0]"=r"(val0), [x1]"=r"(val1) \
 			:[p1]"r"(addr)			\
 			); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#539: FILE: drivers/net/octeontx/base/octeontx_io.h:32:
+#define octeontx_store_pair(val0, val1, addr) __extension__ ({		\
 			asm volatile(			\
 			"stp %x[x0], %x[x1], [%x[p1]]"	\
 			::[x0]"r"(val0), [x1]"r"(val1), [p1]"r"(addr) \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#565: FILE: drivers/net/pfe/base/pfe.h:98:
+#define writel(v, p) __extension__ ({*(volatile unsigned int *)(p) = (v); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#625: FILE: drivers/net/thunderx/base/nicvf_plat.h:58:
+#define nicvf_prefetch_store_keep(_ptr) __extension__ ({\
 	asm volatile("prfm pstl1keep, [%x0]
" : : "r" (_ptr)); })

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#630: FILE: drivers/net/thunderx/base/nicvf_plat.h:62:
+#define NICVF_LOAD_PAIR(reg1, reg2, addr) __extension__ ({		\
 			asm volatile(			\
 			"ldp %x[x1], %x[x0], [%x[p1]]"	\
 			: [x1]"=r"(reg1), [x0]"=r"(reg2)\

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#763: FILE: lib/ethdev/rte_tm.c:43:
+#define RTE_TM_FUNC(port_id, func)			\
+__extension__ ({					\
 	const struct rte_tm_ops *ops =			\
 		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)				\
 		return -rte_errno;			\
 							\
 	if (ops->func == NULL)				\

total: 15 errors, 1 warnings, 534 lines checked