|WARNING| pw137487 [PATCH v1] ethdev: add Linux ethtool link mode conversion

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Feb 29 13:39:08 CET 2024
Previous message (by thread): |SUCCESS| pw137464 [PATCH] net/mlx5: fix action template expansion:
Next message (by thread): |SUCCESS| pw137488-137489 [v10 3/3] net/af_xdp: support AF_XDP DP pinned maps
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/137487

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#141: FILE: lib/ethdev/ethdev_linux_ethtool.c:11:
+/*
+Link modes sorted with index as defined in ethtool.

ERROR:SPACING: space prohibited after that open square bracket '['
#154: FILE: lib/ethdev/ethdev_linux_ethtool.c:24:
+	[  0] =      11, /* ETHTOOL_LINK_MODE_10baseT_Half_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#155: FILE: lib/ethdev/ethdev_linux_ethtool.c:25:
+	[  1] =      10, /* ETHTOOL_LINK_MODE_10baseT_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#156: FILE: lib/ethdev/ethdev_linux_ethtool.c:26:
+	[  2] =     101, /* ETHTOOL_LINK_MODE_100baseT_Half_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#157: FILE: lib/ethdev/ethdev_linux_ethtool.c:27:
+	[  3] =     100, /* ETHTOOL_LINK_MODE_100baseT_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#158: FILE: lib/ethdev/ethdev_linux_ethtool.c:28:
+	[  4] =    1001, /* ETHTOOL_LINK_MODE_1000baseT_Half_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#159: FILE: lib/ethdev/ethdev_linux_ethtool.c:29:
+	[  5] =    1000, /* ETHTOOL_LINK_MODE_1000baseT_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#160: FILE: lib/ethdev/ethdev_linux_ethtool.c:30:
+	[ 12] =   10000, /* ETHTOOL_LINK_MODE_10000baseT_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#161: FILE: lib/ethdev/ethdev_linux_ethtool.c:31:
+	[ 15] =    2500, /* ETHTOOL_LINK_MODE_2500baseX_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#162: FILE: lib/ethdev/ethdev_linux_ethtool.c:32:
+	[ 17] =    1000, /* ETHTOOL_LINK_MODE_1000baseKX_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#163: FILE: lib/ethdev/ethdev_linux_ethtool.c:33:
+	[ 18] =   10000, /* ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#164: FILE: lib/ethdev/ethdev_linux_ethtool.c:34:
+	[ 19] =   10000, /* ETHTOOL_LINK_MODE_10000baseKR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#165: FILE: lib/ethdev/ethdev_linux_ethtool.c:35:
+	[ 20] =   10000, /* ETHTOOL_LINK_MODE_10000baseR_FEC_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#166: FILE: lib/ethdev/ethdev_linux_ethtool.c:36:
+	[ 21] =   20000, /* ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#167: FILE: lib/ethdev/ethdev_linux_ethtool.c:37:
+	[ 22] =   20000, /* ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#168: FILE: lib/ethdev/ethdev_linux_ethtool.c:38:
+	[ 23] =   40000, /* ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#169: FILE: lib/ethdev/ethdev_linux_ethtool.c:39:
+	[ 24] =   40000, /* ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#170: FILE: lib/ethdev/ethdev_linux_ethtool.c:40:
+	[ 25] =   40000, /* ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#171: FILE: lib/ethdev/ethdev_linux_ethtool.c:41:
+	[ 26] =   40000, /* ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#172: FILE: lib/ethdev/ethdev_linux_ethtool.c:42:
+	[ 27] =   56000, /* ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#173: FILE: lib/ethdev/ethdev_linux_ethtool.c:43:
+	[ 28] =   56000, /* ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#174: FILE: lib/ethdev/ethdev_linux_ethtool.c:44:
+	[ 29] =   56000, /* ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#175: FILE: lib/ethdev/ethdev_linux_ethtool.c:45:
+	[ 30] =   56000, /* ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#176: FILE: lib/ethdev/ethdev_linux_ethtool.c:46:
+	[ 31] =   25000, /* ETHTOOL_LINK_MODE_25000baseCR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#177: FILE: lib/ethdev/ethdev_linux_ethtool.c:47:
+	[ 32] =   25000, /* ETHTOOL_LINK_MODE_25000baseKR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#178: FILE: lib/ethdev/ethdev_linux_ethtool.c:48:
+	[ 33] =   25000, /* ETHTOOL_LINK_MODE_25000baseSR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#179: FILE: lib/ethdev/ethdev_linux_ethtool.c:49:
+	[ 34] =   50000, /* ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#180: FILE: lib/ethdev/ethdev_linux_ethtool.c:50:
+	[ 35] =   50000, /* ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#181: FILE: lib/ethdev/ethdev_linux_ethtool.c:51:
+	[ 36] =  100000, /* ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#182: FILE: lib/ethdev/ethdev_linux_ethtool.c:52:
+	[ 37] =  100000, /* ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#183: FILE: lib/ethdev/ethdev_linux_ethtool.c:53:
+	[ 38] =  100000, /* ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#184: FILE: lib/ethdev/ethdev_linux_ethtool.c:54:
+	[ 39] =  100000, /* ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#185: FILE: lib/ethdev/ethdev_linux_ethtool.c:55:
+	[ 40] =   50000, /* ETHTOOL_LINK_MODE_50000baseSR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#186: FILE: lib/ethdev/ethdev_linux_ethtool.c:56:
+	[ 41] =    1000, /* ETHTOOL_LINK_MODE_1000baseX_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#187: FILE: lib/ethdev/ethdev_linux_ethtool.c:57:
+	[ 42] =   10000, /* ETHTOOL_LINK_MODE_10000baseCR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#188: FILE: lib/ethdev/ethdev_linux_ethtool.c:58:
+	[ 43] =   10000, /* ETHTOOL_LINK_MODE_10000baseSR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#189: FILE: lib/ethdev/ethdev_linux_ethtool.c:59:
+	[ 44] =   10000, /* ETHTOOL_LINK_MODE_10000baseLR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#190: FILE: lib/ethdev/ethdev_linux_ethtool.c:60:
+	[ 45] =   10000, /* ETHTOOL_LINK_MODE_10000baseLRM_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#191: FILE: lib/ethdev/ethdev_linux_ethtool.c:61:
+	[ 46] =   10000, /* ETHTOOL_LINK_MODE_10000baseER_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#192: FILE: lib/ethdev/ethdev_linux_ethtool.c:62:
+	[ 47] =    2500, /* ETHTOOL_LINK_MODE_2500baseT_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#193: FILE: lib/ethdev/ethdev_linux_ethtool.c:63:
+	[ 48] =    5000, /* ETHTOOL_LINK_MODE_5000baseT_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#194: FILE: lib/ethdev/ethdev_linux_ethtool.c:64:
+	[ 52] =   50000, /* ETHTOOL_LINK_MODE_50000baseKR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#195: FILE: lib/ethdev/ethdev_linux_ethtool.c:65:
+	[ 53] =   50000, /* ETHTOOL_LINK_MODE_50000baseSR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#196: FILE: lib/ethdev/ethdev_linux_ethtool.c:66:
+	[ 54] =   50000, /* ETHTOOL_LINK_MODE_50000baseCR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#197: FILE: lib/ethdev/ethdev_linux_ethtool.c:67:
+	[ 55] =   50000, /* ETHTOOL_LINK_MODE_50000baseLR_ER_FR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#198: FILE: lib/ethdev/ethdev_linux_ethtool.c:68:
+	[ 56] =   50000, /* ETHTOOL_LINK_MODE_50000baseDR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#199: FILE: lib/ethdev/ethdev_linux_ethtool.c:69:
+	[ 57] =  100000, /* ETHTOOL_LINK_MODE_100000baseKR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#200: FILE: lib/ethdev/ethdev_linux_ethtool.c:70:
+	[ 58] =  100000, /* ETHTOOL_LINK_MODE_100000baseSR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#201: FILE: lib/ethdev/ethdev_linux_ethtool.c:71:
+	[ 59] =  100000, /* ETHTOOL_LINK_MODE_100000baseCR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#202: FILE: lib/ethdev/ethdev_linux_ethtool.c:72:
+	[ 60] =  100000, /* ETHTOOL_LINK_MODE_100000baseLR2_ER2_FR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#203: FILE: lib/ethdev/ethdev_linux_ethtool.c:73:
+	[ 61] =  100000, /* ETHTOOL_LINK_MODE_100000baseDR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#204: FILE: lib/ethdev/ethdev_linux_ethtool.c:74:
+	[ 62] =  200000, /* ETHTOOL_LINK_MODE_200000baseKR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#205: FILE: lib/ethdev/ethdev_linux_ethtool.c:75:
+	[ 63] =  200000, /* ETHTOOL_LINK_MODE_200000baseSR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#206: FILE: lib/ethdev/ethdev_linux_ethtool.c:76:
+	[ 64] =  200000, /* ETHTOOL_LINK_MODE_200000baseLR4_ER4_FR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#207: FILE: lib/ethdev/ethdev_linux_ethtool.c:77:
+	[ 65] =  200000, /* ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#208: FILE: lib/ethdev/ethdev_linux_ethtool.c:78:
+	[ 66] =  200000, /* ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#209: FILE: lib/ethdev/ethdev_linux_ethtool.c:79:
+	[ 67] =     100, /* ETHTOOL_LINK_MODE_100baseT1_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#210: FILE: lib/ethdev/ethdev_linux_ethtool.c:80:
+	[ 68] =    1000, /* ETHTOOL_LINK_MODE_1000baseT1_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#211: FILE: lib/ethdev/ethdev_linux_ethtool.c:81:
+	[ 69] =  400000, /* ETHTOOL_LINK_MODE_400000baseKR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#212: FILE: lib/ethdev/ethdev_linux_ethtool.c:82:
+	[ 70] =  400000, /* ETHTOOL_LINK_MODE_400000baseSR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#213: FILE: lib/ethdev/ethdev_linux_ethtool.c:83:
+	[ 71] =  400000, /* ETHTOOL_LINK_MODE_400000baseLR8_ER8_FR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#214: FILE: lib/ethdev/ethdev_linux_ethtool.c:84:
+	[ 72] =  400000, /* ETHTOOL_LINK_MODE_400000baseDR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#215: FILE: lib/ethdev/ethdev_linux_ethtool.c:85:
+	[ 73] =  400000, /* ETHTOOL_LINK_MODE_400000baseCR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#216: FILE: lib/ethdev/ethdev_linux_ethtool.c:86:
+	[ 75] =  100000, /* ETHTOOL_LINK_MODE_100000baseKR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#217: FILE: lib/ethdev/ethdev_linux_ethtool.c:87:
+	[ 76] =  100000, /* ETHTOOL_LINK_MODE_100000baseSR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#218: FILE: lib/ethdev/ethdev_linux_ethtool.c:88:
+	[ 77] =  100000, /* ETHTOOL_LINK_MODE_100000baseLR_ER_FR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#219: FILE: lib/ethdev/ethdev_linux_ethtool.c:89:
+	[ 78] =  100000, /* ETHTOOL_LINK_MODE_100000baseCR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#220: FILE: lib/ethdev/ethdev_linux_ethtool.c:90:
+	[ 79] =  100000, /* ETHTOOL_LINK_MODE_100000baseDR_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#221: FILE: lib/ethdev/ethdev_linux_ethtool.c:91:
+	[ 80] =  200000, /* ETHTOOL_LINK_MODE_200000baseKR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#222: FILE: lib/ethdev/ethdev_linux_ethtool.c:92:
+	[ 81] =  200000, /* ETHTOOL_LINK_MODE_200000baseSR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#223: FILE: lib/ethdev/ethdev_linux_ethtool.c:93:
+	[ 82] =  200000, /* ETHTOOL_LINK_MODE_200000baseLR2_ER2_FR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#224: FILE: lib/ethdev/ethdev_linux_ethtool.c:94:
+	[ 83] =  200000, /* ETHTOOL_LINK_MODE_200000baseDR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#225: FILE: lib/ethdev/ethdev_linux_ethtool.c:95:
+	[ 84] =  200000, /* ETHTOOL_LINK_MODE_200000baseCR2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#226: FILE: lib/ethdev/ethdev_linux_ethtool.c:96:
+	[ 85] =  400000, /* ETHTOOL_LINK_MODE_400000baseKR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#227: FILE: lib/ethdev/ethdev_linux_ethtool.c:97:
+	[ 86] =  400000, /* ETHTOOL_LINK_MODE_400000baseSR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#228: FILE: lib/ethdev/ethdev_linux_ethtool.c:98:
+	[ 87] =  400000, /* ETHTOOL_LINK_MODE_400000baseLR4_ER4_FR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#229: FILE: lib/ethdev/ethdev_linux_ethtool.c:99:
+	[ 88] =  400000, /* ETHTOOL_LINK_MODE_400000baseDR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#230: FILE: lib/ethdev/ethdev_linux_ethtool.c:100:
+	[ 89] =  400000, /* ETHTOOL_LINK_MODE_400000baseCR4_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#231: FILE: lib/ethdev/ethdev_linux_ethtool.c:101:
+	[ 90] =     101, /* ETHTOOL_LINK_MODE_100baseFX_Half_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#232: FILE: lib/ethdev/ethdev_linux_ethtool.c:102:
+	[ 91] =     100, /* ETHTOOL_LINK_MODE_100baseFX_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#233: FILE: lib/ethdev/ethdev_linux_ethtool.c:103:
+	[ 92] =      10, /* ETHTOOL_LINK_MODE_10baseT1L_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#234: FILE: lib/ethdev/ethdev_linux_ethtool.c:104:
+	[ 93] =  800000, /* ETHTOOL_LINK_MODE_800000baseCR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#235: FILE: lib/ethdev/ethdev_linux_ethtool.c:105:
+	[ 94] =  800000, /* ETHTOOL_LINK_MODE_800000baseKR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#236: FILE: lib/ethdev/ethdev_linux_ethtool.c:106:
+	[ 95] =  800000, /* ETHTOOL_LINK_MODE_800000baseDR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#237: FILE: lib/ethdev/ethdev_linux_ethtool.c:107:
+	[ 96] =  800000, /* ETHTOOL_LINK_MODE_800000baseDR8_2_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#238: FILE: lib/ethdev/ethdev_linux_ethtool.c:108:
+	[ 97] =  800000, /* ETHTOOL_LINK_MODE_800000baseSR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#239: FILE: lib/ethdev/ethdev_linux_ethtool.c:109:
+	[ 98] =  800000, /* ETHTOOL_LINK_MODE_800000baseVR8_Full_BIT */

ERROR:SPACING: space prohibited after that open square bracket '['
#240: FILE: lib/ethdev/ethdev_linux_ethtool.c:110:
+	[ 99] =      10, /* ETHTOOL_LINK_MODE_10baseT1S_Full_BIT */

ERROR:SPACING: spaces required around that '?' (ctx:VxE)
#260: FILE: lib/ethdev/ethdev_linux_ethtool.c:130:
+	duplex = (speed & 1)?
 	                    ^

ERROR:SPACING: spaces required around that ':' (ctx:VxE)
#261: FILE: lib/ethdev/ethdev_linux_ethtool.c:131:
+			RTE_ETH_LINK_HALF_DUPLEX:
 			                        ^

WARNING:INDENTED_LABEL: labels should not be indented
#261: FILE: lib/ethdev/ethdev_linux_ethtool.c:131:
+			RTE_ETH_LINK_HALF_DUPLEX:

ERROR:SPACING: space prohibited before that '++' (ctx:WxB)
#277: FILE: lib/ethdev/ethdev_linux_ethtool.c:147:
+	for (word = 0; word < nwords; word ++) {
 	                                   ^

ERROR:SPACING: space prohibited before that '++' (ctx:WxB)
#278: FILE: lib/ethdev/ethdev_linux_ethtool.c:148:
+		for (bit = 0; bit < 32; bit ++) {
 		                            ^

total: 91 errors, 2 warnings, 227 lines checked
Previous message (by thread): |SUCCESS| pw137464 [PATCH] net/mlx5: fix action template expansion:
Next message (by thread): |SUCCESS| pw137488-137489 [v10 3/3] net/af_xdp: support AF_XDP DP pinned maps
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list