|WARNING| pw142263 [PATCH v4] netdev-offload-dpdk: Support offload of set dscp action

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jul 9 14:14:44 CEST 2024
Previous message (by thread): |SUCCESS| pw142264-142271 [PATCH 8/8] net/mlx5/hws: fix NA64 copy TOS field instead of TTL
Next message (by thread): |WARNING| pw142263 [PATCH v4] netdev-offload-dpdk: Support offload of set dscp action
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/142263

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: lib/netdev-offload-dpdk.c:794:
+    } else if (actions->type == RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP ||$

ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: lib/netdev-offload-dpdk.c:795:
+               actions->type == RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: lib/netdev-offload-dpdk.c:795:
+               actions->type == RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#138: FILE: lib/netdev-offload-dpdk.c:796:
+        const struct rte_flow_action_set_dscp *set_dscp = actions->conf;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: lib/netdev-offload-dpdk.c:796:
+        const struct rte_flow_action_set_dscp *set_dscp = actions->conf;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#139: FILE: lib/netdev-offload-dpdk.c:797:
+        char *dirstr = actions->type == RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: lib/netdev-offload-dpdk.c:797:
+        char *dirstr = actions->type == RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP$

ERROR:CODE_INDENT: code indent should use tabs where possible
#140: FILE: lib/netdev-offload-dpdk.c:798:
+                       ? "set_ipv4_dscp " : "set_ipv6_dscp ";$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: lib/netdev-offload-dpdk.c:798:
+                       ? "set_ipv4_dscp " : "set_ipv6_dscp ";$

ERROR:CODE_INDENT: code indent should use tabs where possible
#142: FILE: lib/netdev-offload-dpdk.c:800:
+        ds_put_cstr(s, dirstr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#142: FILE: lib/netdev-offload-dpdk.c:800:
+        ds_put_cstr(s, dirstr);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: lib/netdev-offload-dpdk.c:801:
+        if (set_dscp) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: lib/netdev-offload-dpdk.c:801:
+        if (set_dscp) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#143: FILE: lib/netdev-offload-dpdk.c:801:
+        if (set_dscp) {
+            ds_put_format(s, "dscp_value %d ", set_dscp->dscp);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#143: FILE: lib/netdev-offload-dpdk.c:801:
+        if (set_dscp) {
+            ds_put_format(s, "dscp_value %d ", set_dscp->dscp);
+        }

ERROR:CODE_INDENT: code indent should use tabs where possible
#144: FILE: lib/netdev-offload-dpdk.c:802:
+            ds_put_format(s, "dscp_value %d ", set_dscp->dscp);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: lib/netdev-offload-dpdk.c:802:
+            ds_put_format(s, "dscp_value %d ", set_dscp->dscp);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#145: FILE: lib/netdev-offload-dpdk.c:803:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#145: FILE: lib/netdev-offload-dpdk.c:803:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#146: FILE: lib/netdev-offload-dpdk.c:804:
+        ds_put_cstr(s, "/ ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: lib/netdev-offload-dpdk.c:804:
+        ds_put_cstr(s, "/ ");$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#153: FILE: lib/netdev-offload-dpdk.c:1849:
         if (!is_all_ones(mask, size)) {
+            if (attr != RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP ||

ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/netdev-offload-dpdk.c:1850:
+            if (attr != RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP ||$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: lib/netdev-offload-dpdk.c:1850:
+            if (attr != RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP ||$

ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: lib/netdev-offload-dpdk.c:1851:
+                attr != RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: lib/netdev-offload-dpdk.c:1851:
+                attr != RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: lib/netdev-offload-dpdk.c:1852:
+                if (mask & IP_ECN_MASK) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: lib/netdev-offload-dpdk.c:1852:
+                if (mask & IP_ECN_MASK) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#157: FILE: lib/netdev-offload-dpdk.c:1852:
+                if (mask & IP_ECN_MASK) {
+                    VLOG_DBG_RL(&rl, "ECN hw offload is not supported!");

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#157: FILE: lib/netdev-offload-dpdk.c:1852:
+                if (mask & IP_ECN_MASK) {
[...]
+                } else {
[...]

ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: lib/netdev-offload-dpdk.c:1853:
+                    VLOG_DBG_RL(&rl, "ECN hw offload is not supported!");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: lib/netdev-offload-dpdk.c:1853:
+                    VLOG_DBG_RL(&rl, "ECN hw offload is not supported!");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: lib/netdev-offload-dpdk.c:1854:
+                } else {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: lib/netdev-offload-dpdk.c:1854:
+                } else {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#159: FILE: lib/netdev-offload-dpdk.c:1854:
+                } else {
+                    goto add_action;

ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: lib/netdev-offload-dpdk.c:1855:
+                    goto add_action;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: lib/netdev-offload-dpdk.c:1855:
+                    goto add_action;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/netdev-offload-dpdk.c:1856:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/netdev-offload-dpdk.c:1856:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: lib/netdev-offload-dpdk.c:1857:
+            } else {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: lib/netdev-offload-dpdk.c:1857:
+            } else {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/netdev-offload-dpdk.c:1858:
+                VLOG_DBG_RL(&rl, "Partial mask is not supported");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/netdev-offload-dpdk.c:1858:
+                VLOG_DBG_RL(&rl, "Partial mask is not supported");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: lib/netdev-offload-dpdk.c:1859:
+            }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/netdev-offload-dpdk.c:1859:
+            }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#178: FILE: lib/netdev-offload-dpdk.c:1937:
+            add_set_flow_action(ipv4_tos, RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: lib/netdev-offload-dpdk.c:1937:
+            add_set_flow_action(ipv4_tos, RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: lib/netdev-offload-dpdk.c:1950:
+            add_set_flow_action(ipv6_tclass,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: lib/netdev-offload-dpdk.c:1950:
+            add_set_flow_action(ipv6_tclass,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#187: FILE: lib/netdev-offload-dpdk.c:1951:
+                                RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: lib/netdev-offload-dpdk.c:1951:
+                                RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP);$

total: 22 errors, 29 warnings, 68 lines checked
Previous message (by thread): |SUCCESS| pw142264-142271 [PATCH 8/8] net/mlx5/hws: fix NA64 copy TOS field instead of TTL
Next message (by thread): |WARNING| pw142263 [PATCH v4] netdev-offload-dpdk: Support offload of set dscp action
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list