|WARNING| pw140544 [PATCH v2 4/4] testpmd: add support for displaying lanes capability

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Jun 2 04:47:24 CEST 2024
Previous message (by thread): |SUCCESS| pw140541-140544 [PATCH v2 4/4] testpmd: add support for displaying lanes capability
Next message (by thread): |WARNING| pw140543 [PATCH v2 3/4] lib/ethdev: add support for displaying lanes capability
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/140544

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: app/test-pmd/cmdline.c:1651:
+        if (speed_capa & RTE_ETH_LINK_SPEED_10M_HD)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: app/test-pmd/cmdline.c:1651:
+        if (speed_capa & RTE_ETH_LINK_SPEED_10M_HD)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#111: FILE: app/test-pmd/cmdline.c:1652:
+                return(" 10 Mbps half-duplex  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: app/test-pmd/cmdline.c:1652:
+                return(" 10 Mbps half-duplex  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#112: FILE: app/test-pmd/cmdline.c:1653:
+        if (speed_capa & RTE_ETH_LINK_SPEED_10M)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#112: FILE: app/test-pmd/cmdline.c:1653:
+        if (speed_capa & RTE_ETH_LINK_SPEED_10M)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#113: FILE: app/test-pmd/cmdline.c:1654:
+                return(" 10 Mbps full-duplex  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: app/test-pmd/cmdline.c:1654:
+                return(" 10 Mbps full-duplex  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#114: FILE: app/test-pmd/cmdline.c:1655:
+        if (speed_capa & RTE_ETH_LINK_SPEED_100M_HD)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: app/test-pmd/cmdline.c:1655:
+        if (speed_capa & RTE_ETH_LINK_SPEED_100M_HD)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#115: FILE: app/test-pmd/cmdline.c:1656:
+                return(" 100 Mbps half-duplex  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: app/test-pmd/cmdline.c:1656:
+                return(" 100 Mbps half-duplex  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#116: FILE: app/test-pmd/cmdline.c:1657:
+        if (speed_capa & RTE_ETH_LINK_SPEED_100M)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: app/test-pmd/cmdline.c:1657:
+        if (speed_capa & RTE_ETH_LINK_SPEED_100M)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: app/test-pmd/cmdline.c:1658:
+                return(" 100 Mbps full-duplex  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: app/test-pmd/cmdline.c:1658:
+                return(" 100 Mbps full-duplex  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: app/test-pmd/cmdline.c:1659:
+        if (speed_capa & RTE_ETH_LINK_SPEED_1G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: app/test-pmd/cmdline.c:1659:
+        if (speed_capa & RTE_ETH_LINK_SPEED_1G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: app/test-pmd/cmdline.c:1660:
+                return(" 1 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: app/test-pmd/cmdline.c:1660:
+                return(" 1 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#120: FILE: app/test-pmd/cmdline.c:1661:
+        if (speed_capa & RTE_ETH_LINK_SPEED_2_5G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#120: FILE: app/test-pmd/cmdline.c:1661:
+        if (speed_capa & RTE_ETH_LINK_SPEED_2_5G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#121: FILE: app/test-pmd/cmdline.c:1662:
+                return(" 2.5 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: app/test-pmd/cmdline.c:1662:
+                return(" 2.5 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: app/test-pmd/cmdline.c:1663:
+        if (speed_capa & RTE_ETH_LINK_SPEED_5G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: app/test-pmd/cmdline.c:1663:
+        if (speed_capa & RTE_ETH_LINK_SPEED_5G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: app/test-pmd/cmdline.c:1664:
+                return(" 5 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: app/test-pmd/cmdline.c:1664:
+                return(" 5 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#124: FILE: app/test-pmd/cmdline.c:1665:
+        if (speed_capa & RTE_ETH_LINK_SPEED_10G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: app/test-pmd/cmdline.c:1665:
+        if (speed_capa & RTE_ETH_LINK_SPEED_10G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#125: FILE: app/test-pmd/cmdline.c:1666:
+                return(" 10 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: app/test-pmd/cmdline.c:1666:
+                return(" 10 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: app/test-pmd/cmdline.c:1667:
+        if (speed_capa & RTE_ETH_LINK_SPEED_20G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: app/test-pmd/cmdline.c:1667:
+        if (speed_capa & RTE_ETH_LINK_SPEED_20G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: app/test-pmd/cmdline.c:1668:
+                return(" 20 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: app/test-pmd/cmdline.c:1668:
+                return(" 20 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: app/test-pmd/cmdline.c:1669:
+        if (speed_capa & RTE_ETH_LINK_SPEED_25G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: app/test-pmd/cmdline.c:1669:
+        if (speed_capa & RTE_ETH_LINK_SPEED_25G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#129: FILE: app/test-pmd/cmdline.c:1670:
+                return(" 25 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: app/test-pmd/cmdline.c:1670:
+                return(" 25 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: app/test-pmd/cmdline.c:1671:
+        if (speed_capa & RTE_ETH_LINK_SPEED_40G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: app/test-pmd/cmdline.c:1671:
+        if (speed_capa & RTE_ETH_LINK_SPEED_40G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: app/test-pmd/cmdline.c:1672:
+                return(" 40 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: app/test-pmd/cmdline.c:1672:
+                return(" 40 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#132: FILE: app/test-pmd/cmdline.c:1673:
+        if (speed_capa & RTE_ETH_LINK_SPEED_50G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: app/test-pmd/cmdline.c:1673:
+        if (speed_capa & RTE_ETH_LINK_SPEED_50G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: app/test-pmd/cmdline.c:1674:
+                return(" 50 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: app/test-pmd/cmdline.c:1674:
+                return(" 50 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: app/test-pmd/cmdline.c:1675:
+        if (speed_capa & RTE_ETH_LINK_SPEED_56G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: app/test-pmd/cmdline.c:1675:
+        if (speed_capa & RTE_ETH_LINK_SPEED_56G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#135: FILE: app/test-pmd/cmdline.c:1676:
+                return(" 56 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: app/test-pmd/cmdline.c:1676:
+                return(" 56 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#136: FILE: app/test-pmd/cmdline.c:1677:
+        if (speed_capa & RTE_ETH_LINK_SPEED_100G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: app/test-pmd/cmdline.c:1677:
+        if (speed_capa & RTE_ETH_LINK_SPEED_100G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: app/test-pmd/cmdline.c:1678:
+                return(" 100 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: app/test-pmd/cmdline.c:1678:
+                return(" 100 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#138: FILE: app/test-pmd/cmdline.c:1679:
+        if (speed_capa & RTE_ETH_LINK_SPEED_200G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: app/test-pmd/cmdline.c:1679:
+        if (speed_capa & RTE_ETH_LINK_SPEED_200G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#139: FILE: app/test-pmd/cmdline.c:1680:
+                return(" 200 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: app/test-pmd/cmdline.c:1680:
+                return(" 200 Gbps  ");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#140: FILE: app/test-pmd/cmdline.c:1681:
+        if (speed_capa & RTE_ETH_LINK_SPEED_400G)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: app/test-pmd/cmdline.c:1681:
+        if (speed_capa & RTE_ETH_LINK_SPEED_400G)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#141: FILE: app/test-pmd/cmdline.c:1682:
+                return(" 400 Gbps  ");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: app/test-pmd/cmdline.c:1682:
+                return(" 400 Gbps  ");$

WARNING:TYPO_SPELLING: 'Unkown' may be misspelled - perhaps 'Unknown'?
#143: FILE: app/test-pmd/cmdline.c:1684:
+	return("Unkown");

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#143: FILE: app/test-pmd/cmdline.c:1684:
+	return("Unkown");

ERROR:C99_COMMENTS: do not use C99 // comments
#155: FILE: app/test-pmd/cmdline.c:1696:
+	//char lanes_speed_str[128] = {0};

ERROR:CODE_INDENT: code indent should use tabs where possible
#167: FILE: app/test-pmd/cmdline.c:1708:
+        if (ret == -ENOTSUP)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#167: FILE: app/test-pmd/cmdline.c:1708:
+        if (ret == -ENOTSUP)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#172: FILE: app/test-pmd/cmdline.c:1713:
+        if (ret == -ENOTSUP)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: app/test-pmd/cmdline.c:1713:
+        if (ret == -ENOTSUP)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#182: FILE: app/test-pmd/cmdline.c:1723:
+        for (i = 1; i <= RTE_ETH_LINK_SPEED_MAX_BIT; i++) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: app/test-pmd/cmdline.c:1723:
+        for (i = 1; i <= RTE_ETH_LINK_SPEED_MAX_BIT; i++) {$

WARNING:SPACING: space prohibited before semicolon
#186: FILE: app/test-pmd/cmdline.c:1727:
+			       get_device_infos_display_speeds(RTE_BIT32(i))) ;

ERROR:CODE_INDENT: code indent should use tabs where possible
#192: FILE: app/test-pmd/cmdline.c:1733:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#192: FILE: app/test-pmd/cmdline.c:1733:
+        }$

total: 38 errors, 38 warnings, 140 lines checked
Previous message (by thread): |SUCCESS| pw140541-140544 [PATCH v2 4/4] testpmd: add support for displaying lanes capability
Next message (by thread): |WARNING| pw140543 [PATCH v2 3/4] lib/ethdev: add support for displaying lanes capability
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list