|WARNING| pw141233 [PATCH 03/19] net/txgbe: fix Tx hang on queue disable

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jun 18 09:14:54 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/141233

_coding style issues_


WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#58: 
Disable PCIe bus master to clear BME when stop hardware, and verify there

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#60: 
master to ensure that there are no packets left to cause Tx hang.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#123: FILE: drivers/net/txgbe/base/txgbe_hw.c:497:
+	/* Prevent the PCI-E bus from hanging by disabling PCI-E master

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#126: FILE: drivers/net/txgbe/base/txgbe_hw.c:500:
+	status = txgbe_set_pcie_master(hw, false);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#140: FILE: drivers/net/txgbe/base/txgbe_hw.c:1187:
+s32 txgbe_set_pcie_master(struct txgbe_hw *hw, bool enable)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#146: FILE: drivers/net/txgbe/base/txgbe_hw.c:1193:
+	if (rte_pci_set_bus_master(pci_dev, enable) < 0) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#147: FILE: drivers/net/txgbe/base/txgbe_hw.c:1194:
+		DEBUGOUT("Cannot configure PCI bus master.");

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#154: FILE: drivers/net/txgbe/base/txgbe_hw.c:1201:
+	/* Exit if master requests are blocked */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#158: FILE: drivers/net/txgbe/base/txgbe_hw.c:1205:
+	/* Poll for master request bit to clear */

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#159: FILE: drivers/net/txgbe/base/txgbe_hw.c:1206:
+	for (i = 0; i < TXGBE_PCI_MASTER_DISABLE_TIMEOUT; i++) {

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#166: FILE: drivers/net/txgbe/base/txgbe_hw.c:1213:
+	status = TXGBE_ERR_MASTER_REQUESTS_PENDING;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#183: FILE: drivers/net/txgbe/base/txgbe_hw.h:43:
+s32 txgbe_set_pcie_master(struct txgbe_hw *hw, bool enable);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#221: FILE: drivers/net/txgbe/base/txgbe_type.h:32:
+#define TXGBE_PCI_MASTER_DISABLE_TIMEOUT	800

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#241: FILE: drivers/net/txgbe/txgbe_ethdev.c:1721:
+	txgbe_set_pcie_master(hw, true);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#250: FILE: drivers/net/txgbe/txgbe_ethdev.c:1986:
+	txgbe_set_pcie_master(hw, true);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#259: FILE: drivers/net/txgbe/txgbe_ethdev.c:2070:
+	txgbe_set_pcie_master(hw, false);

total: 0 errors, 16 warnings, 0 checks, 148 lines checked


More information about the test-report mailing list