|WARNING| pw138484 [PATCH] net/ixgbe: using dpdk-dumpcap capture packet coredump

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138484

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

ERROR:CODE_INDENT: code indent should use tabs where possible
#96: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4329:
+^I    ^I!ad->sdp3_no_tx_disable) {$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#96: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4329:
+^I    ^I!ad->sdp3_no_tx_disable) {$

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#126: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4339:
+				if (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4341:
+^I^I^I^I ^I* the IXGBE_FLAG_NEED_LINK_CONFIG flag only$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#128: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4341:
+^I^I^I^I ^I* the IXGBE_FLAG_NEED_LINK_CONFIG flag only$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#128: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4341:
+					/* To avoid race condition between threads, set
+				 	* the IXGBE_FLAG_NEED_LINK_CONFIG flag only

ERROR:CODE_INDENT: code indent should use tabs where possible
#129: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4342:
+^I^I^I^I ^I* when there is no link thread running.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#129: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4342:
+^I^I^I^I ^I* when there is no link thread running.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4343:
+^I^I^I^I ^I*/$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#130: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4343:
+^I^I^I^I ^I*/$

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#134: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4347:
+							ixgbe_dev_setup_link_thread_handler, dev) < 0) {

WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns
#137: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4350:
+						/* NOTE: review for potential ordering optimization */

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#138: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4351:
+						__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);

total: 4 errors, 10 warnings, 0 checks, 86 lines checked