|WARNING| pw138583 [PATCH 01/46] net/mlx5: use rte stdatomic API

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Mar 20 21:53:42 CET 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138583

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#220: FILE: drivers/net/mlx5/mlx5.h:381:
+	RTE_ATOMIC(uint16_t) refcnt; /* Reference count for representors. */

CHECK:SPACING: No space is necessary after a cast
#229: FILE: drivers/net/mlx5/mlx5.h:484:
+	RTE_ATOMIC(uint16_t) state; /**< Age state (atomically accessed). */

CHECK:SPACING: No space is necessary after a cast
#233: FILE: drivers/net/mlx5/mlx5.h:487:
+	RTE_ATOMIC(uint32_t) sec_since_last_hit;

CHECK:SPACING: No space is necessary after a cast
#242: FILE: drivers/net/mlx5/mlx5.h:500:
+		RTE_ATOMIC(uint32_t) refcnt; /* Only for shared action management. */

CHECK:SPACING: No space is necessary after a cast
#251: FILE: drivers/net/mlx5/mlx5.h:591:
+	volatile RTE_ATOMIC(uint16_t) n_valid; /* Number of valid pools. */

CHECK:SPACING: No space is necessary after a cast
#260: FILE: drivers/net/mlx5/mlx5.h:657:
+	RTE_ATOMIC(uint32_t) refcnt;

CHECK:SPACING: No space is necessary after a cast
#269: FILE: drivers/net/mlx5/mlx5.h:691:
+	RTE_ATOMIC(uint32_t) refcnt; /* geneve tlv object reference counter */

CHECK:SPACING: No space is necessary after a cast
#278: FILE: drivers/net/mlx5/mlx5.h:906:
+	RTE_ATOMIC(uint32_t) ref_cnt;

CHECK:SPACING: No space is necessary after a cast
#287: FILE: drivers/net/mlx5/mlx5.h:1041:
+	RTE_ATOMIC(uint32_t) ref_cnt; /**< Use count. */

CHECK:SPACING: No space is necessary after a cast
#296: FILE: drivers/net/mlx5/mlx5.h:1081:
+	RTE_ATOMIC(uint8_t) state; /**< ASO flow meter state. */

CHECK:SPACING: No space is necessary after a cast
#305: FILE: drivers/net/mlx5/mlx5.h:1127:
+	RTE_ATOMIC(uint32_t) def_policy_ref_cnt;

CHECK:SPACING: No space is necessary after a cast
#315: FILE: drivers/net/mlx5/mlx5.h:1200:
+	RTE_ATOMIC(uint64_t) ci_ts;

CHECK:SPACING: No space is necessary after a cast
#316: FILE: drivers/net/mlx5/mlx5.h:1201:
+	RTE_ATOMIC(uint64_t) ts;

CHECK:SPACING: No space is necessary after a cast
#330: FILE: drivers/net/mlx5/mlx5.h:1224:
+	RTE_ATOMIC(uint64_t) err_miss_int; /* Missed service interrupt. */

CHECK:SPACING: No space is necessary after a cast
#331: FILE: drivers/net/mlx5/mlx5.h:1225:
+	RTE_ATOMIC(uint64_t) err_rearm_queue; /* Rearm Queue errors. */

CHECK:SPACING: No space is necessary after a cast
#332: FILE: drivers/net/mlx5/mlx5.h:1226:
+	RTE_ATOMIC(uint64_t) err_clock_queue; /* Clock Queue errors. */

CHECK:SPACING: No space is necessary after a cast
#333: FILE: drivers/net/mlx5/mlx5.h:1227:
+	RTE_ATOMIC(uint64_t) err_ts_past; /* Timestamp in the past. */

CHECK:SPACING: No space is necessary after a cast
#334: FILE: drivers/net/mlx5/mlx5.h:1228:
+	RTE_ATOMIC(uint64_t) err_ts_future; /* Timestamp in the distant future. */

CHECK:SPACING: No space is necessary after a cast
#335: FILE: drivers/net/mlx5/mlx5.h:1229:
+	RTE_ATOMIC(uint64_t) err_ts_order; /* Timestamp not in ascending order. */

CHECK:SPACING: No space is necessary after a cast
#344: FILE: drivers/net/mlx5/mlx5.h:1290:
+	RTE_ATOMIC(uint32_t) refcnt; /* Action used count in device flows. */

CHECK:SPACING: No space is necessary after a cast
#348: FILE: drivers/net/mlx5/mlx5.h:1293:
+	RTE_ATOMIC(enum mlx5_aso_ct_state) state; /* ASO CT state. */

CHECK:SPACING: No space is necessary after a cast
#364: FILE: drivers/net/mlx5/mlx5.h:1373:
+	RTE_ATOMIC(uint32_t) refcnt; /* Atomically accessed refcnt by flows. */

CHECK:SPACING: No space is necessary after a cast
#373: FILE: drivers/net/mlx5/mlx5.h:1386:
+	RTE_ATOMIC(uint32_t) refcnt;

CHECK:SPACING: No space is necessary after a cast
#384: FILE: drivers/net/mlx5/mlx5.h:1515:
+	RTE_ATOMIC(struct mlx5_hlist *) encaps_decaps; /* Encap/decap action hash list. */

CHECK:SPACING: No space is necessary after a cast
#385: FILE: drivers/net/mlx5/mlx5.h:1516:
+	RTE_ATOMIC(struct mlx5_hlist *) modify_cmds;

CHECK:SPACING: No space is necessary after a cast
#386: FILE: drivers/net/mlx5/mlx5.h:1517:
+	RTE_ATOMIC(struct mlx5_hlist *) tag_table;

CHECK:SPACING: No space is necessary after a cast
#395: FILE: drivers/net/mlx5/mlx5.h:1528:
+	RTE_ATOMIC(struct mlx5_indexed_pool *) mdh_ipools[MLX5_MAX_MODIFY_NUM];

CHECK:SPACING: No space is necessary after a cast
#404: FILE: drivers/net/mlx5/mlx5.h:1573:
+	RTE_ATOMIC(void *) hca_bar;

CHECK:SPACING: No space is necessary after a cast
#413: FILE: drivers/net/mlx5/mlx5.h:1638:
+	RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */

CHECK:SPACING: No space is necessary after a cast
#422: FILE: drivers/net/mlx5/mlx5.h:1829:
+	RTE_ATOMIC(uint8_t) state; /* object state */

CHECK:SPACING: No space is necessary after a cast
#431: FILE: drivers/net/mlx5/mlx5.h:1958:
+	RTE_ATOMIC(uint32_t) hws_mark_refcnt; /* HWS mark action reference counter. */

CHECK:SPACING: No space is necessary after a cast
#440: FILE: drivers/net/mlx5/mlx5.h:2010:
+	RTE_ATOMIC(uint16_t) shared_refcnt; /* HW steering host reference counter. */

CHECK:SPACING: No space is necessary after a cast
#557: FILE: drivers/net/mlx5/mlx5_flow.h:1052:
+	RTE_ATOMIC(uint32_t) refctn;

CHECK:SPACING: No space is necessary after a cast
#566: FILE: drivers/net/mlx5/mlx5_flow.h:1473:
+	RTE_ATOMIC(uint32_t) refcnt;  /* Reference counter. */

CHECK:SPACING: No space is necessary after a cast
#575: FILE: drivers/net/mlx5/mlx5_flow.h:1505:
+	RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */

CHECK:SPACING: No space is necessary after a cast
#584: FILE: drivers/net/mlx5/mlx5_flow.h:1858:
+	RTE_ATOMIC(uint32_t) refcnt; /**< Atomically accessed refcnt. */

CHECK:SPACING: No space is necessary after a cast
#732: FILE: drivers/net/mlx5/mlx5_flow_dv.c:316:
+flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, RTE_ATOMIC(struct mlx5_hlist *) *phl,

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#732: FILE: drivers/net/mlx5/mlx5_flow_dv.c:316:
+flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, RTE_ATOMIC(struct mlx5_hlist *) *phl,
                                                                                       ^

CHECK:SPACING: No space is necessary after a cast
#1677: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:104:
+	RTE_ATOMIC(uint32_t) query_gen __rte_cache_aligned;

CHECK:SPACING: No space is necessary after a cast
#1687: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:137:
+	RTE_ATOMIC(uint32_t) timeout; /* Aging timeout in seconds (atomically accessed). */

CHECK:SPACING: No space is necessary after a cast
#1688: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:138:
+	RTE_ATOMIC(uint32_t) sec_since_last_hit;

CHECK:SPACING: No space is necessary after a cast
#1691: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:140:
+	RTE_ATOMIC(uint16_t) state; /* AGE state (atomically accessed). */

CHECK:SPACING: No space is necessary after a cast
#1713: FILE: drivers/net/mlx5/mlx5_rx.h:176:
+	RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */

CHECK:SPACING: No space is necessary after a cast
#1722: FILE: drivers/net/mlx5/mlx5_rx.h:191:
+	RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */

CHECK:SPACING: No space is necessary after a cast
#1897: FILE: drivers/net/mlx5/mlx5_tx.h:182:
+	RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */

CHECK:SPACING: No space is necessary after a cast
#2219: FILE: drivers/net/mlx5/mlx5_utils.h:243:
+	volatile RTE_ATOMIC(uint32_t) n_trunk_valid; /* Trunks allocated. */

CHECK:SPACING: No space is necessary after a cast
#2228: FILE: drivers/net/mlx5/mlx5_utils.h:269:
+			RTE_ATOMIC(struct mlx5_indexed_cache *) gc;

total: 0 errors, 0 warnings, 47 checks, 1840 lines checked
Please use __rte_cache_aligned only for struct or union types alignment.


More information about the test-report mailing list