|WARNING| pw139008 [PATCH v20 12/14] log: add optional support of syslog

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Mar 30 17:47:26 CET 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139008

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#114: FILE: app/test/test_eal_flags.c:990:
+	const char *argv4[] = {prgname, prefix, mp_flag, "--syslog=both"};

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#117: FILE: app/test/test_eal_flags.c:992:
+	const char *argv5[] = {prgname, prefix, mp_flag, "--syslog=invalid"};

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#260: FILE: lib/log/log.c:513:
+	else
[...]
 	if (log_timestamp_enabled())

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#288: FILE: lib/log/log_stubs.c:5:
+#include <stdio.h>

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#320: FILE: lib/log/log_syslog.c:3:
+#include <stdio.h>

total: 0 errors, 5 warnings, 240 lines checked


More information about the test-report mailing list