|WARNING| pw140079 [PATCH v6 06/45] net/hns3: use rte stdatomic API

checkpatch at dpdk.org checkpatch at dpdk.org
Tue May 14 18:37:25 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/140079

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#125: FILE: drivers/net/hns3/hns3_cmd.c:47:
+	static RTE_ATOMIC(uint64_t) hns3_dma_memzone_id;

CHECK:SPACING: No space is necessary after a cast
#213: FILE: drivers/net/hns3/hns3_ethdev.c:102:
+						 RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#213: FILE: drivers/net/hns3/hns3_ethdev.c:102:
+						 RTE_ATOMIC(uint64_t) *levels);
 						                      ^

CHECK:SPACING: No space is necessary after a cast
#303: FILE: drivers/net/hns3/hns3_ethdev.c:5680:
+hns3_get_reset_level(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#303: FILE: drivers/net/hns3/hns3_ethdev.c:5680:
+hns3_get_reset_level(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                     ^

CHECK:SPACING: No space is necessary after a cast
#366: FILE: drivers/net/hns3/hns3_ethdev.h:404:
+	RTE_ATOMIC(uint16_t) schedule;

CHECK:SPACING: No space is necessary after a cast
#369: FILE: drivers/net/hns3/hns3_ethdev.h:406:
+	RTE_ATOMIC(uint16_t) resetting;

CHECK:SPACING: No space is necessary after a cast
#372: FILE: drivers/net/hns3/hns3_ethdev.h:408:
+	RTE_ATOMIC(uint16_t) disable_cmd;

CHECK:SPACING: No space is necessary after a cast
#377: FILE: drivers/net/hns3/hns3_ethdev.h:412:
+	RTE_ATOMIC(uint64_t) pending;

CHECK:SPACING: No space is necessary after a cast
#380: FILE: drivers/net/hns3/hns3_ethdev.h:414:
+	RTE_ATOMIC(uint64_t) request;

CHECK:SPACING: No space is necessary after a cast
#389: FILE: drivers/net/hns3/hns3_ethdev.h:502:
+	RTE_ATOMIC(unsigned int) secondary_cnt; /* Number of secondary processes init'd. */

CHECK:SPACING: No space is necessary after a cast
#398: FILE: drivers/net/hns3/hns3_ethdev.h:847:
+	RTE_ATOMIC(uint16_t) pf_push_lsc_cap;

CHECK:SPACING: No space is necessary after a cast
#407: FILE: drivers/net/hns3/hns3_ethdev.h:856:
+	RTE_ATOMIC(uint16_t) poll_job_started; /* whether poll job is started */

CHECK:SPACING: No space is necessary after a cast
#416: FILE: drivers/net/hns3/hns3_ethdev.h:1000:
+hns3_atomic_test_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#416: FILE: drivers/net/hns3/hns3_ethdev.h:1000:
+hns3_atomic_test_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                     ^

CHECK:SPACING: No space is necessary after a cast
#427: FILE: drivers/net/hns3/hns3_ethdev.h:1009:
+hns3_atomic_set_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#427: FILE: drivers/net/hns3/hns3_ethdev.h:1009:
+hns3_atomic_set_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                    ^

CHECK:SPACING: No space is necessary after a cast
#435: FILE: drivers/net/hns3/hns3_ethdev.h:1015:
+hns3_atomic_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#435: FILE: drivers/net/hns3/hns3_ethdev.h:1015:
+hns3_atomic_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                      ^

CHECK:SPACING: No space is necessary after a cast
#443: FILE: drivers/net/hns3/hns3_ethdev.h:1021:
+hns3_test_and_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#443: FILE: drivers/net/hns3/hns3_ethdev.h:1021:
+hns3_test_and_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                        ^

CHECK:SPACING: No space is necessary after a cast
#461: FILE: drivers/net/hns3/hns3_ethdev_vf.c:40:
+						    RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#461: FILE: drivers/net/hns3/hns3_ethdev_vf.c:40:
+						    RTE_ATOMIC(uint64_t) *levels);
 						                         ^

CHECK:SPACING: No space is necessary after a cast
#645: FILE: drivers/net/hns3/hns3_ethdev_vf.c:2033:
+hns3vf_get_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#645: FILE: drivers/net/hns3/hns3_ethdev_vf.c:2033:
+hns3vf_get_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)
                                                                 ^

CHECK:SPACING: No space is necessary after a cast
#690: FILE: drivers/net/hns3/hns3_intr.c:2036:
+		     int num, RTE_ATOMIC(uint64_t) *levels,

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#690: FILE: drivers/net/hns3/hns3_intr.c:2036:
+		     int num, RTE_ATOMIC(uint64_t) *levels,
 		                                   ^

CHECK:SPACING: No space is necessary after a cast
#699: FILE: drivers/net/hns3/hns3_intr.c:2107:
+hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#699: FILE: drivers/net/hns3/hns3_intr.c:2107:
+hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                       ^

CHECK:SPACING: No space is necessary after a cast
#708: FILE: drivers/net/hns3/hns3_intr.c:2154:
+hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#708: FILE: drivers/net/hns3/hns3_intr.c:2154:
+hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                      ^

CHECK:SPACING: No space is necessary after a cast
#772: FILE: drivers/net/hns3/hns3_intr.c:2540:
+hns3_clear_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#772: FILE: drivers/net/hns3/hns3_intr.c:2540:
+hns3_clear_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)
                                                                 ^

CHECK:SPACING: No space is necessary after a cast
#822: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#822: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);
                                                                            ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#822: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: No space is necessary after a cast
#823: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#823: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);
                                                                           ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#823: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

total: 0 errors, 2 warnings, 37 checks, 722 lines checked


More information about the test-report mailing list