|WARNING| pw145956 [PATCH v5 9/9] net/zxdh: add zxdh dev configure ops

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Oct 15 07:51:40 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145956

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'buff_size != 0'
#178: FILE: drivers/net/zxdh/zxdh_common.c:313:
+	if ((buff_size != 0) && (buff == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'buff == NULL'
#178: FILE: drivers/net/zxdh/zxdh_common.c:313:
+	if ((buff_size != 0) && (buff == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxmode->mq_mode != RTE_ETH_MQ_RX_RSS'
#664: FILE: drivers/net/zxdh/zxdh_ethdev.c:764:
+	if ((rxmode->mq_mode != RTE_ETH_MQ_RX_RSS) && (rxmode->mq_mode != RTE_ETH_MQ_RX_NONE))	{

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxmode->mq_mode != RTE_ETH_MQ_RX_NONE'
#664: FILE: drivers/net/zxdh/zxdh_ethdev.c:764:
+	if ((rxmode->mq_mode != RTE_ETH_MQ_RX_RSS) && (rxmode->mq_mode != RTE_ETH_MQ_RX_NONE))	{

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxmode->mq_mode != RTE_ETH_MQ_RX_RSS'
#673: FILE: drivers/net/zxdh/zxdh_ethdev.c:773:
+	if ((rxmode->mq_mode != RTE_ETH_MQ_RX_RSS) && (rxmode->mq_mode != RTE_ETH_MQ_RX_NONE))	{

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxmode->mq_mode != RTE_ETH_MQ_RX_NONE'
#673: FILE: drivers/net/zxdh/zxdh_ethdev.c:773:
+	if ((rxmode->mq_mode != RTE_ETH_MQ_RX_RSS) && (rxmode->mq_mode != RTE_ETH_MQ_RX_NONE))	{

WARNING:TYPO_SPELLING: 'que' may be misspelled - perhaps 'queue'?
#700: FILE: drivers/net/zxdh/zxdh_ethdev.c:800:
+		/*no que changed */

WARNING:TYPO_SPELLING: 'que' may be misspelled - perhaps 'queue'?
#704: FILE: drivers/net/zxdh/zxdh_ethdev.c:804:
+	PMD_DRV_LOG(DEBUG, "que changed need reset ");

total: 0 errors, 2 warnings, 6 checks, 1212 lines checked
Please use __rte_aligned only for struct or union types alignment.


More information about the test-report mailing list